Closed PxSonny closed 6 years ago
Maybe I can improve it.
Sure 👍 Any help is appreciated.
@Astrian @PxSonny This is awesome. I love the fact that more people are translating it. Maybe u guys can help finish this as well. My team finished translating it a while back but i never get the time to edit the files and upload them. https://docs.google.com/document/d/1Z4_IkjJj3lvI69KVGzrWTkwKCUGrbDhiBtSltw3uOR8/edit
@Skillz4Killz I see but I think it's messy so much 😂 Maybe I can re-translate it with GitBook
Maybe let's not re-translate haha but finalize everything using my PR and @Skillz4Killz document. How does GitBook work? It can be based on a fork of a repo?
@PxSonny Same as GitHub but Git the book. I will review the Google Docs and try to improve it
Yes please improve away. I am happy to see others also want to help translate it.
How about using GitHub pages instead of GitBooks? We can create a branch in the repo that will allow us to be able to maintain every language of the docs right inside this very repo.
@Skillz4Killz Great idea.
@Skillz4Killz Let's do that. How do we get started? I can translate into French too ^^
@genexp How does using GitHub pages in a separate branch here in the repo to store all the different versions of the translated docs sound?
@PxSonny I already sent up French as well a while back. Would love any help updating it though and fixing anything we may have missed.
@Skillz4Killz Yes, if you have any document I can have a look on it.
I'm a bit on edge about merging translations. Can we add something to say translated documents may be out of date? There are likely going to be cases where translated documents are out of date with their English counterparts as this is a community effort.
https://shimo.im/doc/vj48YTpy0CwUHp0v?r=V9GZ4/
Just translated some little part of the document, and I will continue to translate it
@DominicGunn Yea that can easily be added at the top of the docs. But to be honest aren't English docs also outdated as well? It's kept by the English community just as the other languages will be kept by their community.
@PxSonny https://github.com/madglory/gamelocker-vainglory/pull/164 I'm not sure where the files went but I uploaded them there and realized how much work and time to took me to do that.
English is the official language for standards and documentation and should always be the primary source, I'm with Dom.
Yeah, I don't see any harm adding a disclaimer: "the documentation can be outdated, please check English one for most up-to-date" in the different translation.
@Skillz4Killz Oh I see. I'll get the files from your commit and check it. :+1:
Sounds awesome!
On Wed, Aug 23, 2017 at 10:22 PM, Sonny Alves Dias <notifications@github.com
wrote:
Yeah, I don't see any harm adding a disclaimer: "the documentation can be outdated, please check English one for most up-to-date" in the different translation.
@Skillz4Killz https://github.com/skillz4killz Oh I see. I'll get the files from your commit and check it. 👍
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madglory/gamelocker-vainglory/pull/255#issuecomment-324514155, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADMCXYUoguRCXtYDdz_mwAdiiUUTSIks5sbN5RgaJpZM4O-Eji .
-- Brian Corrigan Managing Partner / Principal Engineer at MadGlory https://www.linkedin.com/company/2657284 Wb: http://madglory.com http://www.madglory.com/ Tw: @madglory Ph: 518.867.1439
Anyone know to make Slate hosted on github pages? Ive been looking into it but it actually requires running scripts and hosting it locally so I am not sure how to set up the GitHub Pages. Does anyone know how to set that up with Slate?
Hey @PxSonny can you see #299 and #301. I think this will help get this shipped! Thanks for pushing us!
Ok, I spoke to @PxSonny offline on this. We've committed the main translations, so we can now let this one follow that format.
Changes proposed: