SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

PBE Access #260

Open svperfecta opened 7 years ago

svperfecta commented 7 years ago

Hi Folks - I'd like to get a list together of who needs PBE access. For API developers, there are a few responsibilities (and benefits!) of having access.

What you'll do: 1) You'll be responsible for creating new schema files that describe each patch versions data, and helping to get them into this repository. This will ensure each patch is clearly documented, prior to being released, and prior versions of the data format are documented. (Once documented, they can even be transformed to look more like current data.. more on that if interested). 2) You'll be responsible for helping to spot data bugs (think, 2.4 patch) and reporting them prior to submission. This will ensuring fewer data issues.

What you'll get:

We are looking for 4 or 5 teams to join up!

svperfecta commented 7 years ago

NOTE: We will try to be fair in who gets access. This will take into account the popularity of the project you're maintaining, and your ability to contribute to the PBE program.

cklugewicz commented 7 years ago

I'd certainly be interested in this -- how do we apply?

Skillz4Killz commented 7 years ago

Sign me up! Im already in PBE btw so not sure if that makes a difference. Not sure if you know but we already have the number of community developers you wanted in PBE btw.

BTW Is this a 1 invite per person or 1 invite per team? I mean my team has 5 developers on it and we are bringing on another 4 soon do they all get invited or just the 1 person? How do invites work?

PierreAndreis commented 7 years ago

I think the invite will be based per API key. So if you team shares the same api key, then you will all have access.

schneefux commented 7 years ago

As backend developer of VainSocial.com, I am interested. I would share the key or the data with the rest of our team (stormcaller/@kvahuja, Shiqan) as needed.

kamaelxiii commented 7 years ago

Developer of Halcyon Chats and I’m a PBE Tester for iOS.

Skillz4Killz commented 7 years ago

@PierreAndreis If it was API Key how does that give closer access to Dev team or early knowledge of changes? This is only possible if you are in the PBE. API key would only provide early access to data from what I understood.

ghost commented 7 years ago

Count me in too please. Thanks!

svperfecta commented 7 years ago

This is working on the tech end now. I am chatting with Nivmett on Tuesday about process stuff and how to get everyone enrolled. Brian is rolling out Schema links today too, so that should tie this all up :)

schneefux commented 7 years ago

What is the status? The changelog mentions "PBE data is now available to approved community developers", judo asked for our team's mail, but we haven't gotten any instructions on how to actually get the data.

schneefux commented 6 years ago

@genexp Any update on this? 2.9 is coming next week.

schneefux commented 6 years ago

@genexp What is the status?

You have promised this to be the workaround for schema and data breakages every update. There have been 3 updates now, each of them introducing breaking changes that I had to fix after the data was live.

PierreAndreis commented 6 years ago

correct me if i'm wrong, but all breaking changes has been communicated properly, days before the update @schneefux

But I do believe that we need PBE access, which in this case needs to be more regularized than just giving access (to avoid leaks etc)

cklugewicz commented 6 years ago

Actually, if you want to be precise about it, NOTHING regarding API changes has EVER been communicated “properly” ... I would consider “proper” communication to be an official changelog posted by an SEMC employee who is part of the dev team responsible for the API in an official channel, such as the SEMC Slack or the API web portal.

I am not belittling your efforts, Pierre — if it weren’t for you, we would have no information AT ALL. It’s just that it’s not your job, and by your own admission, you’re not part of the team responsible for the API, so the information isn’t first hand.

I think that’s a sad state of affairs, to be frank.

schneefux commented 6 years ago

Changes that haven't been communicated at all, not even weeks after the release and that broke my logic:

317:

Added fortress minion crit attack Oct 11 Baptiste "Tether" attacks, Flicker crit, Reim crit, Taka Legendary Talent Aug 25 Grace crit, Baptiste attacks Aug 20

332:

Buff_Item_HitByStormguardBanner is now Buff_Item_StormguardBanner_Damage Buff_Item_Spellfire_Damage has been added Buff_Lorelai_FishFoodDamagePerSecond (Lorelei A) has been added Buff_Lorelai_FishFoodDelay (Lorelei A) has been added Buff_Reza_C_DamagePostTeleport (Reza C) has been added

PierreAndreis commented 6 years ago

@schneefux @cklugewicz you made a point, I totally agree with you both

Hopefully we can get this sorted out soon :/