SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Bug: 504 for queries outside the data retention period #271

Closed schneefux closed 7 years ago

schneefux commented 7 years ago

248:

Queries for months that don't have data should return 404 instead of a timeout error.

svperfecta commented 7 years ago

This is the root cause of #170 too. We should be enforcing limitations on query parameters, or silently defaulting them.

Here's the weird thing.. 1) We want to allow future dates, because of small time inconsistencies between everyone's concept of "current time". Without this "end date" doesn't always work. 2) We do not want to allow past dates out of the 120 day period, though the same #1 problem can occur.

How does everyone expect this would work?

svperfecta commented 7 years ago

Fixed!