SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Dictionaries #294

Closed svperfecta closed 7 years ago

svperfecta commented 7 years ago

Fixes #293

Changes proposed:

svperfecta commented 7 years ago

NOTE: The VST dictionary is notably inconsistent. I think what we want to do is lookup a value, and find the VST. That's hard, and probably really does require an array instead of a dictionary / map.

PierreAndreis commented 7 years ago

Make sure we delete the resources from /assets/resources folder if we are going to make them dictionaries

svperfecta commented 7 years ago

Hey @PierreAndreis I didn't actually realize you moved them. Let me merge this with what you did (or throw this away if not needed).

PierreAndreis commented 7 years ago

I do think these dictionaries are better than what we have though!

PierreAndreis commented 7 years ago

I agree with Skillz4Killz

svperfecta commented 7 years ago

Hey @PierreAndreis @Skillz4Killz Reversed them! How does it look now?

PierreAndreis commented 7 years ago

awesome!