search

SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Deprecation: played field #295

Closed svperfecta closed 6 years ago

svperfecta commented 7 years ago

played is now hardcoded to 0, since we have the new played_casual, aral, etc. fields.

Everyone has a month now to use the new fields, and so in 2.9 we should remove this one.

Skillz4Killz commented 7 years ago

This is awesome, I love that we are improving the API. But maybe in future cases to do this a little differently might be better.

For example, we could have left played as the sum of all games for this update and this way for any projects that are using played which is probably most that use player profiles. This gives projects the ability to have time to prepare to move with advance notice so that by 2.9 every project stays working and on 2.9 the played is removed and there was a 4-week advance notice to every team so there was enough time.

I woke up to a bunch of DMs asking why EZLBot was reporting total matches played as 0. I won't be able to access the server to fix this for a while, unfortunately, due to a family vacation.

svperfecta commented 7 years ago

Yeah, going forward it will work version by version. So players that have patchVersion 2.9 (or whatever) would have the update, but older ones wont.

jaloisi834 commented 6 years ago

All of the 'played' and 'played_' fields have been deprecated. We will notify everyone before removing them.