search

SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Invalid blue roster id for match 0ded8df6-b9b0-11e7-9667-02ff607182ab #330

Closed turindev closed 6 years ago

turindev commented 6 years ago

When user muzu (region: SEA) retrieves matches, one of the matches has an invalid blue roster guid:

Match: 0ded8df6-b9b0-11e7-9667-02ff607182ab Blue Roster: 0ded8df6-b9b0-11e7-9667-02ff607182ab-r0

Is this by design?

schneefux commented 6 years ago

I hope not, we have a database that is built on the premise of IDs always being a valid UUID v4 (@genexp confirmed this will always be the case)! We can't rewrite millions of char(36) columns?!

What is even the motivation behind appending -r0? (roster 0 I guess?) The relationship property already defines the relationships? Unless a client has a really bad database design or fetching logic I see zero reason to move away from a predictable fixed-length GUID…?

Why did this match pass the validation? If this is intended, why is it not in the CHANGELOG?

dominicgunn commented 6 years ago

+1, this is service breaking.

PierreAndreis commented 6 years ago

Also breaking here, +1