SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Bug: Spectator missing from match #331

Open sscots opened 6 years ago

sscots commented 6 years ago

I'm trying to tag matches by spectator, and I know the match below had a spectator and it's not appearing in the match object. id: 1f8ded32-bf58-11e7-82e4-02e17183594c

{
            "type": "match",
            "id": "1f8ded32-bf58-11e7-82e4-02e17183594c",
            "attributes": {
                "createdAt": "2017-11-01T22:58:08Z",
                "duration": 1478,
                "gameMode": "private_party_draft_match",
                "patchVersion": "2.9",
                "shardId": "na",
                "stats": {
                    "endGameReason": "victory",
                    "queue": "private_party_draft_match"
                },
                "titleId": "semc-vainglory"
            },
            "relationships": {
                "assets": {
                    "data": [
                        {
                            "type": "asset",
                            "id": "f1115684-bf5b-11e7-9b6c-0a586460aa52"
                        }
                    ]
                },
                "rosters": {
                    "data": [
                        {
                            "type": "roster",
                            "id": "f12d81b0-bf5b-11e7-ace6-4b09d1ef6a27"
                        },
                        {
                            "type": "roster",
                            "id": "f12d81b4-bf5b-11e7-ace6-4b09d1ef6a27"
                        }
                    ]
                },
                "rounds": {
                    "data": []
                },
                "spectators": {
                    "data": []
                }
            },
            "links": {
                "schema": "https://raw.githubusercontent.com/madglory/gamelocker-vainglory/master/schemas/2.9/match_index.json",
                "self": "https://api.dc01.gamelockerapp.com/shards/na/matches/1f8ded32-bf58-11e7-82e4-02e17183594c"
            }
        }
...

Expected Behaviour

Spectators array should contain at least one reference

Current Behaviour

There are no spectators listed

Possible Solution

Steps to Reproduce (for bugs)

  1. Call https://api.dc01.gamelockerapp.com/shards/na/matches/1f8ded32-bf58-11e7-82e4-02e17183594c

Context

I'm trying to filter matches by spectator, after I've pulled them through the api. Ideally, I'd also like to query the matches endpoint by spectator but I know that's not possible right now. It would be nice to have though.