SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Bug: invalid asset json #334

Closed schneefux closed 5 years ago

schneefux commented 6 years ago

https://cdn.gamelockerapp.com/semc-vainglory/eu/2017/11/15/23/28/b6a9f69a-ca5c-11e7-94fc-0a586460aaa8-telemetry.json

schneefux commented 6 years ago
        {
            "time": "2017-11-15T23:23:50+0000",
            "type": "HealTarget",
            "payload": {
                "Team": "Left",
                "Actor": "*Idris*",
                "TargetActor": "*Idris*",
                "TargetTeam": "Left",
                "Source": "Buff_Item_HealingFlask",
                "Heal": 52,
                "Healed": 52,
                "IsHero": 1,
                "TargetIsHero": 1
            }
        },
        {
            "time": "2017-11-15T23:23:51+0000",
            "type": "DealDamage",
            "payload": {
                "Team": "Right",
                "Actor": "*Grace*",
                "Target": "*Idris*",
                "Source": "Buff_Item_StormguardBanner_Damage",
                "Damage": 11,
                "Dealt": 11,
                "IsHero": 1,
                "TargetIsHero": 1
            }
        },
        {
            "time": "2017{ "
            time ": "
            2017 - 11 - 15 T23: 23: 55 + 0000 ", "
            type ": "
            DealDamage ", "
            payload ": { "
            Team ": "
            Left ", "
            Actor ": " * Idris * ", "
            Target ": " * Grace * ", "
            Source ": "
            Ability__Idris__DefaultAttack ", "
            Damage ": 372, "
            Dealt ":  139, "
            IsHero ": 1, "
            TargetIsHero ": 1 } },{ "
            time ": "
            2017 - 11 - 15 T23: 23: 55 + 0000 ", "

FUBAR.

dominicgunn commented 6 years ago

Oh wow, what happened here? Super busted. Who is responsible for generating this? Is this done by SEMC and respected by MadGlory, or is MadGlory doing some transformation here? Could we get some clarity for the sake of organising tickets correctly?

jaloisi834 commented 6 years ago

We have minimal involvement with the telemetry data. We only turn it into JSON and perform a few string operations on it. This data appears to have come through broken, so we will be sending it over to SEMC for review.