Request: Accurate and Up-To-Date High Quality Image Assets

[BrianGLHF]

A lot of community developers are at the point where they need accurate and up to date high quality image assets for their projects in order to take their Vainglory data to the proper level of quality standards and sophistication (aka not half-baked).

These assets should include but are not limited to the following library types..

• Hero profile squares
• Hero splash art
• Hero images on transparent backgrounds
• Item icons that are up to date
• Role icons (Carry, Captain, Jungle)
• In game UI icons (Creeps, Gold, Kills, Deaths, Assists, Turrets icons, Battle Log event icons, and any other UI icons)
• In game currency images on transparent backgrounds (including all keys, Opals, ICE and Glory)
• In game ping icons

All images in each of the categories should be of the same high quality and standards with no deviations in image quality through the library.

Thanks! :)

[PierreAndreis]

[BrianGLHF]

@PierreAndreis Good lookin' out 👍

[svperfecta]

This one is definitely happening.

[svperfecta]

Hey @BrianGlory sent you a private message in Discord with some art. If this looks good, we'll share.

[BrianGLHF]

@genexp That looks great but some small changes to the art must be made before sharing. Thank you!

[kvahuja]

are you also planning to expose hero and item master data like we have on VaingloryFire?

[kvahuja]

also, can you share some samples of what sort of icons are you planning? if it works for our designs i won't do a lot of those

[BrianGLHF]

are you also planning to expose hero and item master data like we have on VaingloryFire?

@kvahuja - Are you talking about item and hero base stats? that's a stretch goal of 1.0. *fingers crossed*

[kvahuja]

@BrianGlory

i guess i will start working on the same, if we get it, all we will need is to replace with API calls :)

[kamaelxiii]

Please add the Support Badge in the assets. Thank you!

[PierreAndreis]

can we have some update on when https://github.com/madglory/gamelocker-vainglory/issues/37#issuecomment-279601194 will be available on api? @genexp

[kvahuja]

@BrianGlory - in wake of recent changed, i would like to suggest a few things when you guys do this: if you guys plan to do this live images

1. make assets available over a CDN and not via API
2. send in request headers so that they are cached by the client (on browser or something) so that the apps in browsers are making calls again and again
3. please don't put this on a rate limit

if you plan to share (download from FTP) offline and then host as required

1. I am okay with this, just provide a location on S3 or something where players with auth can download and sync
2. try to have some sort of a programmatic sync method. so don't expose it via a web download zip. this way we can code to sync from time to time.

thanks

[svperfecta]

We're pulling this into the ItemDB feature, if you guys up-vote it :)

[schneefux]

Can you reopen the issue until it is fixed? We are still using assets we downloaded from the Vainglory site and don't have explicit permission to use them in our applications.

[kvahuja]

@genexp 2 upvotes does it? there are at least 6 sites which use the API. it's a humble request to setup an email notification/broadcast to reach out to us. I don't track this GIT hub repository all the time and we may miss something important.

also, while you close this, can you please link this to the other one that is open?

I would like to see how you guys are planning to release itemDB?

@genexp / @bguilder

[BrianGLHF]

I believe at the time @genexp was referring to "up voting" as voting for it in the poll that was emailed to developers around that time. I don't believe that itemDB got as many votes as other items in the poll (sadly!) and it was generally overlooked and seemingly not as high of a priority for others when discussed in #feature-voting on Discord. Comments by MadGlory in chats have given the impression that some work is being done on it but other things that have been voted on are of a higher priority. See #announcements in Discord for the poll results and how those are being prioritized.

[BrianGLHF]

We still do not have any official assets from SEMC.

[svperfecta]

So...

1) We're going to keep image assets here. 2) Surprise incoming.

[ghost]

Please move assets into a separate repo (gamelocker-vainglory-assets?). Disable issues on that repo and add a link on README to this repo to submit an issue. Docs Contributors should not be forced to download big assets to contribute.

We could probably version them in the form of releases and follow Vainglory App versioning for that repo.

[ClarkThyLord]

I propose we have two main branches to this rep. The “Light version", where one would update the docs and json resources; and the “heavy version”, everything the light version has plus assets, aka. Imgs. This way anyone who wants to update the docs will just download and edit the “light version”; and won’t have to download 350+ MB of assets that come with the “heavy version”, which aren’t even relevant to the docs. While someone who wants to start creating content, with the api, right away will be able to download the “heavy version”; and start creating content within a few minutes of reading the docs with all the assets he/she could possibly want.

light version - a branch: The master branch where everything that's on the rep right now would be. This is the branch that you download and send your pull request to if you’re going to update the gamelocker VainGlory docs and json resources. Includes:

• gamelocker VainGlory docs
• json resources

heavy version - a branch: This would be a side branch from Master, light version, it will have the docs and resources up to date including assets. This is the branch that you download and send your pull request to if you’re going to edit assets.

Includes:

• gamelocker VainGlory docs
• json resources
• assets(A.K.A. imgs)

If we do this we’ll have community maintained assets; and while GitHub isn’t relatively meant for this I can’t think of another service which can make this easily accessible, to both get and post, while still maintaining quality control. It would be awesome for SEMC to give us assets, but it’s not going to happen anytime soon, and even if they do it may not be what we expect. While community maintained will be exactly what we expect, because we’re the ones who decide what assets are added.

[PierreAndreis]

I'm working on this guys, soon we will have a repo with most of assets.

[svperfecta]

Hey folks - I think our proposal is to just pull them into this repo. 1) I'd like everything in one place 2) Branches wont work, when you checkout a git repo you get all branches anyways. 3) We're talking hundreds of MB, i don't really think that's a huge repo? If we end up with GB we should find another plan. 4) If we can have them in one place, there's potential to pull them into a project, deploy on CDN, etc.

[kvahuja]

based on my experience - adding assets will eventually slow down the repo and it will be a deterrent for any new committer. I dont mind the putting in a repo, can you not create a new repo. so you have one each for assets and documentation. (or a Google Drive or something). Git is a bad place to be putting any sort of binaries.

[cklugewicz]

I agree, I don't think they should be in the same repo. For one thing, a 350 MB repo is a lot when you're downloading over cellular, which I do quite often -- I clone repos all the time to my mobile devices, which btw, generally have much more significant storage constraints than PCs or laptops.

[schneefux]

There is git-lfs, which is designed for storing binary files in git, it is supported by GitHub. https://git-lfs.github.com/

It requires users to have git-lfs installed or only the "pointer files" will be downloaded.

[svperfecta]

@schneefux yeah, great idea :) Let's pull them out when there's a problem?

[svperfecta]

(Just trying to get issues fixed, and closed.)

[PierreAndreis]

bump