SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Bug: LifetimeGold Units are different for different players #56

Closed kvahuja closed 7 years ago

kvahuja commented 7 years ago

Look at these 2 responses. notice how the level 2 player has a larger lifetimeGold value than the level 30 player. i presume the units are different for them. do we know what those units are and at what point do they change??

{
  "shardId": "",
  "stats": {
    "played_ranked": 0,
    "winStreak": 1,
    "played": 0,
    "wins": 1,
    "level": 2,
    "lifetimeGold": 14194.75,
    "lossStreak": 0,
    "xp": 207
  },
  "name": "LighteningThief",
  "titleId": ""
}
{
  "shardId": "",
  "stats": {
    "played_ranked": 319,
    "winStreak": 0,
    "played": 1404,
    "wins": 729,
    "level": 30,
    "lifetimeGold": 8876.875,
    "lossStreak": 2,
    "xp": 175450
  },
  "name": "StormCallerSr",
  "titleId": ""
}
schneefux commented 7 years ago

lifetimeGold on player is actually the amount of gold the player had at the end of their last match. It should be moved to participant.attributes.stats.gold instead.

svperfecta commented 7 years ago

Duplicate of #141

svperfecta commented 7 years ago

This