SuperGO2 / supergo2-issues

Issue tracker for SuperGO2 project
6 stars 5 forks source link

Shield regen from gems is giving the wrong type of effect. #414

Open 0Nimroth opened 1 year ago

0Nimroth commented 1 year ago

Describe the bug Currently the % shield regeneration from blue quadra and triad gems is increasing the effect of shield regeneration modules.

To Reproduce Steps to reproduce the behavior:

  1. Make a fleet with a 3k stack of ships with a lot of energy armor modules, no shield negation modules and with 1x shield regenerator.
  2. Make sure the commander doesn't have a charger chip or blue quadra or blue triad gems
  3. Send it into arena against an opponent with a ballistic fleet that can take out all the shield hitpoints in one round but not hurt the structure.
  4. Note down how much shield has regenerated in round 2.
  5. Repeat the arena test but this time with added blue quadra gems on the commander.
  6. Notice that this time the amount regenated has increased by the same percentage as the regeneration stat on the gems provide.
  7. Repeat the test an additional time, this time with an identical stack of ships except no shield regenator module, but with quadra gems still on the commander.
  8. Notice you get no regeneration from the gems on their own.

Expected behavior The shield regeneration stat from quadra or triad gems is not supposed to increase the effect of other forms of regeneration. Instead it is supposed to add a flat amount of regeneration based on a percentage of the total amount of shields on the stack of ships. If you have 10% shield regeneration from the gems and have a stack of ships with a total of 10mil shield hp, then you should be getting an additional 1mil shield regeneration every round. This is also meant to be unaffected by effective stacksize and instead based on the entire stack, even if it is a 3k stack on a common commander.