SuperGoodSoft / solidus_taxjar

Support for using TaxJar to handle tax calculations in Solidus
BSD 3-Clause "New" or "Revised" License
12 stars 12 forks source link

Could not find generator 'super_good:solidus_taxjar:install'. #213

Closed diegomichel closed 1 year ago

diegomichel commented 1 year ago

I wonder if the README is out of date, as explained on this thread: https://github.com/SuperGoodSoft/solidus_taxjar/issues/67

forkata commented 1 year ago

Hey @diegomichel 👋🏼 I am curious what discrepancies you are seeing and what version of the library you are running?

We are in preparation for releasing version 1.0 of this gem so the README should reflect the current master branch.

diegomichel commented 1 year ago

Hey @forkata, on the master branch, it shows the following instructions:

Screenshot 2023-01-25 at 13 30 07

But if I try to run the generator it doesn't find it: bundle exec rails generate super_good:solidus_taxjar:install

Could not find generator 'super_good:solidus_taxjar:install'.

Gemfile.lock

+ 612     super_good-solidus_taxjar (0.18.2)                                                                                                                                                              
+ 613       solidus_core (>= 2.4.0)                                                                                                                                                                       
+ 614       solidus_support                                                                                                                                                                               
+ 615       taxjar-ruby           

Maybe I should point Gemfile to use the master branch on the repo 🤔

Thanks 🙏

forkata commented 1 year ago

Hey @diegomichel! I think that is where the confusion is. The README should reflect the changes in the branch you are on, but we did have an issue previously like you mentioned where it was incorrect for the version of this gem (0.18.2) you are running.

We subsequently added a generator to this extension, but have not released a new version of this gem since then. You would need to reference the library through github in your Gemfile and run agains the master branch to get that.

diegomichel commented 1 year ago

Thanks @forkata adding this to the Gemfile makes the generator run (ran into other issues but that's another history lol)

gem 'super_good-solidus_taxjar', git: 'https://github.com/SuperGoodSoft/solidus_taxjar'
forkata commented 1 year ago

Glad that worked out for you. We are going to be doing a 1.0 release in the next couple of weeks which should hopefully remove any confusion over this.