SuperGoodSoft / solidus_taxjar

Support for using TaxJar to handle tax calculations in Solidus
BSD 3-Clause "New" or "Revised" License
12 stars 12 forks source link

[221] Create sync logs for replace transaction jobs #225

Closed Noah-Silvera closed 1 year ago

Noah-Silvera commented 1 year ago

What is the goal of this PR?

We missed the act of creating refund transaction log objects even though the object type exists

This creates sync logs when replacing a transaction on taxjar

How do you manually test these changes? (if applicable)

  1. Perform a refund
    • [x] Ensure the appropriate logs are created and displayed in the UI
    • [x] Ensure the refund is performed successfully on TaxJar

Merge Checklist

nvandoorn commented 1 year ago

This has been updated to remove the double return value in favour of using an association. A change log entry has been added as well.