search

SuperGoodSoft / solidus_taxjar

Support for using TaxJar to handle tax calculations in Solidus
BSD 3-Clause "New" or "Revised" License
12 stars 13 forks source link

Update how we load factories to be more compatible with Solidus #232

Closed forkata closed 1 year ago

forkata commented 1 year ago

What is the goal of this PR?

This is a temporary fix until our PR to solidus_dev_support is merged that allows us to have deeper namespacing of the extension folder structure.

https://github.com/solidusio/solidus_dev_support/pull/207

This change also updates how we run the CI jobs to separate the current / older versions into separate jobs. With the new Solidus v4.0 release, we still have some work to get the extension passing agains that version as well as main. Splitting the jobs allows us to also run each one with a different version of Ruby, which is now required as the solidus_sample repo requires Ruby >= 3.0 for Solidus v4 and main.

NOTE: There is some overlap in the test runs as run-specs-solidus-current will run tests on v3.2, v3.3, v3.4 and v4.0 (on Ruby 3) and run-specs-solidus-older will run specs on v3.2, v3.3 and v3.4 (on Ruby 2.7). The last one is what I changed the Required check to be on, since we’re not passing on 4.0 yet.

Fixes #230.

How do you manually test these changes? (if applicable)

forkata commented 1 year ago

It looks like we are now failing specs on Solidus 4.0, we can make that check optional, but I am also unsure where to rename the Required check from the old one?

This is the failure we need to fix for tests to pass on main and v4.0

Failure/Error: include ::Spree::Event::Subscriber

NameError:
  uninitialized constant Spree::Event