Hard-code order number in refund feature spec

SuperGoodSoft / solidus_taxjar

Support for using TaxJar to handle tax calculations in Solidus

BSD 3-Clause "New" or "Revised" License

12 stars 12 forks source link

Hard-code order number in refund feature spec #240

Closed nvandoorn closed 1 year ago

nvandoorn commented 1 year ago

Prior to this change, this spec may fail because the order number differs from the order number in the cassette. To solve this, we hard-code the value from the cassette into the test.

Note that re-recording this cassette may require incrementing the order number.

What is the goal of this PR?

How do you manually test these changes? (if applicable)

Do a thing
- [ ] Assert a result

Merge Checklist

[ ] Run the manual tests
[ ] Update the changelog

Screenshots

nvandoorn commented 1 year ago

Drafting this until we remove the pending from the refund feature spec.

benjaminwil commented 1 year ago

@nvandoorn Is this closed forever? Did we determine this isn't an issue?