search

SuperGoodSoft / solidus_taxjar

Support for using TaxJar to handle tax calculations in Solidus
BSD 3-Clause "New" or "Revised" License
12 stars 12 forks source link

Get tests and binstubs working against Solidus `main` #254

Closed forkata closed 10 months ago

forkata commented 10 months ago

What is the goal of this PR?

  1. To get the build against Solidus main green! This required to appease Zeitwerk by migrating one of our Deface overrides to the DSL format.
  2. To be able to generate a sandbox app against Solidus main
  3. To have a frontend to test with 😓

Many thanks to @AlistairNorman for pairing on this with me as I was dreading having to work on this change!

How do you manually test these changes? (if applicable)

  1. Visit the admin Taxes section
    • [x] Ensure the TaxJar settings tab is there
  2. Test the bin/sandbox binstub on a few different branches, this was only tested on main

Merge Checklist

Screenshots

N/A

benjaminwil commented 10 months ago

@forkata It looks like the manual tests have been completed. We just need a CHANGELOG entry and then we can merge. ✨

benjaminwil commented 10 months ago

I updated the CHANGELOG.

benjaminwil commented 10 months ago

I resolved an issue where the --admin-preview flag did not exist and caused an error with the bin/sandbox script if SOLIDUS_BRANCH was set to versions older than 4.2.

I manually tested that bin/sandbox works against SOLIDUS_BRANCHes: