SuperGouge / ChanThreadWatch

Fork of the original discontinued ChanThreadWatch.
90 stars 13 forks source link

Bugfix: Move Threads on Remove Completed - Broken when category is set #87

Closed jwshields closed 5 years ago

jwshields commented 5 years ago

This PR fixes an issue which I've just run into-

Problem: If you have moving completed threads enabled and have threads with categories set, upon removal, the threads will not be moved to the proper completed directory and will stay in the downloads\category directory.

This is due to the dotnet Directory.Move method; it expects all directories in the destination path to exist upon move, else it will fail to move the source file/dir. My change adds three lines, it checks if the thread Category is not an empty string, and if so, creates the directory above the threads destination. The function is smart enough to know if the specified directory already exists and will more-or-less ignore the creation.

Built and tested the movement on my machine and it worked without issue. I don't believe this should introduce any other quirks since thread.Category is set to an empty string on the loading of a thread.

SuperGouge commented 5 years ago

Thanks for the fix!