SuperHouse / esp-open-rtos

Open source FreeRTOS-based ESP8266 software framework
BSD 3-Clause "New" or "Revised" License
1.53k stars 491 forks source link

Enabling LWIP SYS_DEBUG causes compilation errors #573

Closed jeffsf closed 6 years ago

jeffsf commented 6 years ago

If a local copy of lwipopts.h is created that enables SYS_DEBUG the build fails. May well be an upstream issue.

755c755
< //#define LWIP_DEBUG
---
> #define LWIP_DEBUG
843c843
< #define SYS_DEBUG                       LWIP_DBG_OFF
---
> #define SYS_DEBUG                       LWIP_DBG_ON
/Volumes/esp-build/esp-open-rtos/lwip/lwip/src/core/timeouts.c: In function 'sys_timeouts_init':
/Volumes/esp-build/esp-open-rtos/lwip/lwip/src/core/timeouts.c:259:5: error: too few arguments to function 'sys_timeout_abs'
     sys_timeout_abs(now + lwip_cyclic_timers[i].interval_ms, lwip_cyclic_timer, LWIP_CONST_CAST(void *, &lwip_cyclic_timers[i]));
     ^
/Volumes/esp-build/esp-open-rtos/lwip/lwip/src/core/timeouts.c:177:1: note: declared here
 sys_timeout_abs(u32_t abs_time, sys_timeout_handler handler, void *arg, const char *handler_name)
 ^
make: *** [build/lwip//lwip/src/core/timeouts.o] Error 1
jeffsf commented 6 years ago

Confirmed that #574 as merged into current master appears to have resolved this.

Closing, thanks @ourairquality