search

SuperHouse / esp-open-rtos

Open source FreeRTOS-based ESP8266 software framework
BSD 3-Clause "New" or "Revised" License
1.53k stars 491 forks source link

Deleted the definition fo HD44780_I2C #600

Closed ekalyvio closed 3 years ago

ekalyvio commented 6 years ago

There is no reason of the following 3 lines:

#ifndef HD44780_I2C
#define HD44780_I2C 1
#endif

They actually conflict with the option _HD44780I2C = 0 on the esp8266/esp-open-rtos/examples/hd44780_lcd/Makefile.

On the other hand if no option is added to the Makefile, the component.mk file on folder /esp8266/esp-open-rtos/extras/hd44780 declares it as: HD44780_I2C ?= 1

As such there is no issue totally deleting these 3 lines.