SuperKaioken / odbc2kml

Automatically exported from code.google.com/p/odbc2kml
0 stars 0 forks source link

Condition comparisons should use string comparisons #217

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
All comparisons using "==" or "!=" should be string comparisons.  We should 
not try and parse out doubles for == and !=.

Original issue reported on code.google.com by nind...@gmail.com on 13 Apr 2010 at 8:17

GoogleCodeExporter commented 9 years ago
Make sure you get rid of the "else if"s in Condition.getErrorText() that relate 
to 
this. Currently, 2 of these conditions will present an error if you use a 
comparison 
operator with a string in the corresponding textbox.

Original comment by mbbowser@gmail.com on 14 Apr 2010 at 8:06

GoogleCodeExporter commented 9 years ago
In order to make these changes, you would need to go into evaluate condition 
which is
a function in the condition class. Currently, the function tries to parse as a
double, if that fails it resorts to strings; however, if anything can be parsed 
as a
double after it views it as a string, it will not allow the condition to work. 

Also, in the addconditiontoicon and addcondiiontooverlay functions in the 
ConnDetails
cs, you will want to edit the small tidbit of code that won't allow database 
columns
to be mapped that has strings and doubles.

Original comment by Ctan...@gmail.com on 20 Apr 2010 at 6:43