search

SuperMarcus / NineAnimator

An elegant way of discovering anime on iOS.
https://9ani.app
GNU General Public License v3.0
809 stars 99 forks source link

[BUG] Some episodes on pantsubase.tv instantly downloads but I am not able to watch them #258

Closed Melaquera73 closed 3 years ago

Melaquera73 commented 3 years ago

STOP!! Before submitting this bug report, make sure you have filled out the information below and renamed the title of this issue (ex. [BUG] UrlError when trying to stream an episode on 9ani.app). The information you provide helps us diagnose the problem and organize our issue tracker.

Describe the bug Replace this line with a clear and concise description of what the bug is.

To Reproduce Replace this with the steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Replace this line with a clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Device: Replace the following with the device on which you're experiencing this issue.

Crash Log

If applicable, paste the crash log inside this block.
(Goto Settings.app -> Privacy -> Analytics & Improvements -> Analytics Data to find crash logs)

Additional context Add any other context about the problem here.

uttiya10 commented 3 years ago

Can you please say what anime and what episode you downloaded using pantsubase? It would also be great if you can provide a screen recording of the issue!

Melaquera73 commented 3 years ago

I have noticed that it happened on quite a few so far but here is one :- Attack on Titan season 3 episode 12

https://user-images.githubusercontent.com/83816474/119720387-56baad80-be83-11eb-8e8b-594213698d88.MP4

uttiya10 commented 3 years ago

Thank you for the information. I see exactly why the episode is not being downloaded properly, and I'll fix the issue when I have time!

Technical root cause: The source is incorrectly marking the video files as mp4, instead of m3u8 streams. This causes the app to use URLSession to download the episode, instead of AVAssetDownloadURLSession, resulting in a broken download.

uttiya10 commented 3 years ago

Can you please try these steps:

  1. Delete the broken downloaded episode
  2. Download and install this pre-release version of the app: https://github.com/uttiya10/NineAnimator/suites/2841095925/artifacts/63386188
  3. Try downloading the episode again, and report if the issue is fixed
Melaquera73 commented 3 years ago

Thank you very much, It works now!

Melaquera73 commented 3 years ago

It doesn't work again.It either doesn't download at all or tells me to try other sources.

uttiya10 commented 3 years ago

May i know the anime and the episode number that you are trying to download?

Melaquera73 commented 3 years ago

None of the episodes from any anime I tried to download downloaded but here is the first one I found not downloading:

Episode 1 of Steins;Gate

Melaquera73 commented 3 years ago

After I download the same episode from other sources it appears like thisimage

Melaquera73 commented 3 years ago

?

joshhhhyyyy commented 3 years ago

please try the latest commit if you use xcode.

if you dont, im hoping someone will send the artifact link because i honestly dont know where it is haha.

ive had the same issues with you. its not just downloading but streaming as well, seems to be fixed with the latest commit

Melaquera73 commented 3 years ago

Haha,thanks!

uttiya10 commented 3 years ago

Sorry for the very late reply! A bunch of the code base has been going through a internal restructuring, which is why it's taken some time for the sources to be fixed.

Here is where you can download the beta version of NineAnimator, which should have the sources fixed: https://github.com/SuperMarcus/NineAnimator/actions/runs/992458342

Melaquera73 commented 3 years ago

Some episodes are downloading and some aren't

Steins:Gate 0:

Episodes 1 and 2 are downloading but not 3 and when I try to stream episodes that aren't downloading this appears:image

joshhhhyyyy commented 3 years ago

i can confirm this problem too, but im pretty sure this is a completely new issue.

its a VERY VERY VERY VERY VERY common thing for a new bug to appear BECAUSE you fixed another so i wasnt that suprised.

just wait for the next major release because they are doing a lot of cool stuff in the background

doubt this will be fixed soon but it'll be cool if they do

uttiya10 commented 3 years ago

I can confirm this is NOT an issue with NineAnimator. The episode your trying to watch is simply not available on the website either, see the screenshot below.

Therefore, since this website doesn't have the episode you're looking for, I recommend using another source, like arrayanime.

image

Melaquera73 commented 3 years ago

Oh,but I can download it from their site does that have nothing to do with this?

Awsomedude commented 3 years ago

I can confirm this is NOT an issue with NineAnimator. The episode your trying to watch is simply not available on the website either, see the screenshot below.

Therefore, since this website doesn't have the episode you're looking for, I recommend using another source, like arrayanime.

image

It does work if you change the server on the site, Pantsudrive to Gogo-Stream.

uttiya10 commented 3 years ago

If you would like to use gogo-stream, you can switch your source in NineAnimator to gogoanime

uttiya10 commented 3 years ago

Oh,but I can download it from their site does that have nothing to do with this?

Their download link sends you to gogo's website. If you want to use gogoanime to download, follow the comment above^^

Melaquera73 commented 3 years ago

Ah,I see!