search

SuperMarcus / NineAnimator

An elegant way of discovering anime on iOS.
https://9ani.app
GNU General Public License v3.0
806 stars 99 forks source link

[Feature Request] Add AnimeWorld Support #69

Closed Raffa2001 closed 4 years ago

Raffa2001 commented 4 years ago

Hi i would like if you add this italian server https://www.animeworld.tv/ who host ita sub and dub, and i can help with the traslation, i done a sketch photo6034833224938664320

SuperMarcus commented 4 years ago

As I've responded in the old subreddit thread, I'd love to implement another international source to the app. However, since I'm not very good at Italian I might misinterpret some parts of the website.

Also, we're currently working on implementing Anime Unity, another Italian anime source, into the app. See #68 and #40.

Catta1997 commented 4 years ago

I can add that too, it's not very different from AnimeUnity so I have to edit only the parsing. If for @SuperMarcus is ok I can add the support on the same pull request

Raffa2001 commented 4 years ago

I can add that too, it's not very different from AnimeUnity so I have to edit only the parsing. If for @SuperMarcus is ok I can add the support on the same pull request

It will be even better if he make a way to add your own servers

Catta1997 commented 4 years ago

---ITA--- comunque in locale l'ho creato e funziona. Riguardo alla possibilità di aggiungere i server non è semplice, bisogna fare il parsing dei siti web per trovare i link e l'unico modo è modificare il progetto dell'applicazione ---ENG--- however locally I created it and it works. As for the ability to add the servers yourself is not easy, you need to analyze the websites to find the links and use them. the only way is to edit the project

SuperMarcus commented 4 years ago

It appears that AnimeWorld is also not region blocked. It may be a good alternative for Italian audiences living in other parts of the world. Would you mind working on this as well @Catta1997?

Looks like this website is structured similarly to 9anime. So implementations here may serve as a template.

Raffa2001 commented 4 years ago

It appears that AnimeWorld is also not region blocked. It may be a good alternative for Italian audiences living in other parts of the world. Would you mind working on this as well @Catta1997?

Looks like this website is structured similarly to 9anime. So implementations here may serve as a template.

Yeah dude, he have the same structure of the design and pages

Catta1997 commented 4 years ago

@SuperMarcus, JSON search appears to have some limitations. In fact if you search for "Conan" instead of "Detective Conan" the search returns an empty JSON (also with Postman) , I think that the json is made by "suggested" search. Also JSON will return only 5 element instead 25 (for example with Detective Conan)

Catta1997 commented 4 years ago

For AnimeWorld I did a Pull Request

SuperMarcus commented 4 years ago

JSON search appears to have some limitations...

Noted. I guess I'll have to revert those changes. I rewrote part of the old search agent because there was a spin loop in the more() method.

https://github.com/SuperMarcus/NineAnimator/blob/dd281dbbf837d6e49f29e903baad04b9cc98d0ea/NineAnimator/Models/Anime%20Source/animeunity.it/AnimeUnity%2BSearch.swift#L47-L48

more() may be called from the main thread, so we don’t want that.

Raffa2001 commented 4 years ago

JSON search appears to have some limitations...

Noted. I guess I'll have to revert those changes. I rewrote part of the old search agent because there was a spin loop in the more() method.

https://github.com/SuperMarcus/NineAnimator/blob/dd281dbbf837d6e49f29e903baad04b9cc98d0ea/NineAnimator/Models/Anime%20Source/animeunity.it/AnimeUnity%2BSearch.swift#L47-L48

more() may be called from the main thread, so we don’t want that.

I will try to contact the founders to help you with the code so it will be easier

Raffa2001 commented 4 years ago

JSON search appears to have some limitations...

Noted. I guess I'll have to revert those changes. I rewrote part of the old search agent because there was a spin loop in the more() method.

https://github.com/SuperMarcus/NineAnimator/blob/dd281dbbf837d6e49f29e903baad04b9cc98d0ea/NineAnimator/Models/Anime%20Source/animeunity.it/AnimeUnity%2BSearch.swift#L47-L48

more() may be called from the main thread, so we don’t want that.

btw i think you write in the wrong session, this is the animeworld.tv, and you put a link to the animeunity.it code

SuperMarcus commented 4 years ago

@Raffa2001 you are absolutely correct. This should have been posted in #68's discussions. I was just responding to Catta1997's comment.

DanielVip3 commented 4 years ago

Hi! I'm the (new) developer of AnimeWorld.tv.

We'd like to ask you to not add our site within your app's sources, to avoid load from webscraping and requests (also, the owner's a bit mad 'bout others using our things, y'know). Please keep in mind webscraping is illegal, and we have all the copyright on our code source, so please, we ask you to not webscrape on our site. Also, we don't earn nothing about this webscraping, because our ads are not in the player, and we're just losing bandwidth from our own servers to serve all this people which doesn't even know our site and never comes over it. We most likely are only losing from this.

For @Raffa2001: we're also minding to make an app in the near future, with our APIs, so there's no need of this right now. Al limite fatti una webview del sito e veditela tu (che poi P.S. abbiamo una webview su Aptoide se proprio vuoi, fatta da me qualche mesetto fa per chi aveva questa necessità) in attesa della nostra app.

Thanks to all the developer community of this open-source project and thanks for trying to add AnimeWorld, we really like your work(yeah, the owner just downloaded your app and likes it really much) and keep going with other sources.

SuperMarcus commented 4 years ago

Since the representative of AnimeWorld has spoken, I will be closing this issue now.