SuperMartijn642 / AdditionalLanterns

5 stars 6 forks source link

[Feature] Compat with Connectable Chains (just add the forge chains tag) #41

Open Mysticpasta1 opened 3 months ago

Mysticpasta1 commented 3 months ago

Is your feature request related to a problem? Please describe.

...

for compat with the mods connectable chains, all chains need the chains tag from forge to be recognized by the code as a connectable one.

Describe the solution you'd like

... just tag all the chains in the mod with the forge chain tag forge:chains

SuperMartijn642 commented 2 months ago

all chains need the chains tag from forge

Neither Forge nor NeoForge seems to have an item or block tag for chains. https://github.com/MinecraftForge/MinecraftForge/blob/1.20.x/src/main/java/net/minecraftforge/common/Tags.java#L32 https://github.com/neoforged/NeoForge/blob/1.20.x/src/main/java/net/neoforged/neoforge/common/Tags.java#L24

SuperMartijn642 commented 2 months ago

As far as I can tell, the only tag used by Connectible Chains is an item tag c:chains https://github.com/lilypuree/ConnectibleChains/blob/1.20.1/src/main/resources/data/c/tags/items/chains.json

Mysticpasta1 commented 2 months ago

oh huh I wonder how that can be added