search

SuperMartijn642 / ChunkLoaders

15 stars 11 forks source link

[Crash] Tried to enter the world #50

Closed DoctorSigma closed 1 year ago

DoctorSigma commented 2 years ago

Version Info

**Are you using OptiFine?: No

Steps to Reproduce 1)Tried to enter the world

Crash report (~/logs/latest.log) crash - https://gist.github.com/4a0d1c313b69d54455a3cbfb153c99f2.git latest - https://gist.github.com/e3c5f489950d5608188b58f6c2b5e830.git

SuperMartijn642 commented 2 years ago

The crash appears to be caused by Applied Energistics.

DoctorSigma commented 2 years ago

I was told as follows:

It's incompatible. The chunkloader mod is loading the chunk before the world has completed loading. Forge has it's own chunkloading API, which is compatible with AE2. Sorry, but we're not going to implement specific compatibility with this mod in 1.16.

Could you, if ae2 is installed in the modpack, use the API mentioned above?

SuperMartijn642 commented 2 years ago

Chunk Loaders is already using the API's provided.

The problem seems to come from this line: https://github.com/SuperMartijn642/ChunkLoaders/blob/5cb2d4967b0e3e5a2e593d2fae2583cd4af890d6/src/main/java/com/supermartijn642/chunkloaders/ChunkLoaderUtil.java#L133 The line is part of loading code for Chunk Loaders' world capability. During loading, the ChunkLoaderUtil$ChunkTracker#add method ends up calling World#setChunkForced which also causes the chunk to load.

The issue seems to be a rare occurrence as it hasn't been reported before. I can also not reproduce the issue with just Chunk Loaders and Applied Energistics 2 installed.

I am working on redoing pretty much all of Chunk Loaders. I will not be fixing it right now, as this appears to be an uncommon issue and the code for it will be redone anyways.

SuperMartijn642 commented 1 year ago

The problem is fixed now in version 1.2.0 of Chunk Loaders. Thank you for reporting the issue!