SuperMartijn642 / Fusion

25 stars 5 forks source link

[Bug] folders named fusion in resource packs cause Fusion to break #85

Closed steelphoenix4 closed 1 week ago

steelphoenix4 commented 2 weeks ago

Version Info

Are you using OptiFine: No

Description of the Bug Models stop loading, resulting in random blocks having missing textures.

Steps to Reproduce Create a Fusion resource pack with a folder in the models folder named "fusion".

Screenshots image image image Nothing was changed between screenshots, just f3+t resource pack reloads.

latest.log

SuperMartijn642 commented 1 week ago

Failed to load model mekanismgenerators:models/block/fusion/port.json Invalid json for predicate type 'fusion:match_block'! Unknown block 'mekanismgenerators:reactor_frame'!

Failed to load model mekanismgenerators:models/block/fusion/frame.json Invalid json for predicate type 'fusion:match_block'! Unknown block 'mekanismgenerators:reactor_port'!

The log does show some errors in the model jsons for some of the models. Are you sure mekanismgenerators:reactor_frame and mekanismgenerators:reactor_port are the correct registry names for the blocks you want?

My guess is that when a model fails to load due to a valid error in the model json, like the incorrect block ids above, it for some reason breaks future loading. Since models are not loaded in a particular order, that might explain why it seems to break random models each time when reloading resources. Pretty sure it has nothing to do with the folder name though.

steelphoenix4 commented 1 week ago

Apologies, apparently I am very bad at isolating problems. You are correct the name of the block was not in fact
mekanismgenerators:reactor_frame but mekanismgenerators:fusion_reactor_frame. Everything works as intended.

SuperMartijn642 commented 1 week ago

Of course the weird random broken models is not ideal, but I am redoing a large part of the mod anyways, so we'll have to see after that.