SuperMartijn642 / MovingElevators

22 stars 17 forks source link

[Bug] Cabin size not being saved #102

Closed JeremyToler closed 2 years ago

JeremyToler commented 2 years ago

Every time the server reboots or I change dimensions and come back the cabin size setting returns to default. I am on Minecraft 1.18.1 Forge 39.0.76 Moving Elevators 1.3.3

SuperMartijn642 commented 2 years ago

When testing both on server and in single player, the cabin size settings show up fine after a restart or dimension change.

Are there any steps to reproduce the issue? Are you using any other mods? If so, which other mods? Are there any errors in the logs/latest.log files for the server or client?

JeremyToler commented 2 years ago

To reproduce the issue I am right clicking the side of the controller, setting the cabin size, then entering the nether, coming back from the nether, and at that point if I use the elevator only part of the cabin moves, if I right click the side of a controller its back to the default size.

I am using a lot of mods :(

02/14/2022  05:59 PM        21,745,558 alexsmobs-1.17.0.jar
02/14/2022  05:20 PM            46,051 appleskin-forge-mc1.18-2.3.0.jar
02/14/2022  06:39 PM           504,912 architectury-3.6.17.jar
02/15/2022  11:06 AM            78,390 BetterModsButton-v3.1.0-1.18.1-Forge.jar
02/14/2022  05:23 PM        21,242,206 BiomesOPlenty-1.18.1-15.0.0.105-universal.jar
02/14/2022  06:15 PM            37,189 caelus-forge-1.18-3.0.0.1.jar
02/14/2022  05:52 PM           318,958 carryon-1.18.1-1.17.0.7.jar
02/14/2022  05:59 PM           501,649 citadel-1.10.10-1.18.jar
02/14/2022  06:34 PM         1,133,103 cloth-config-6.2.57-forge.jar
02/14/2022  05:20 PM            10,215 Clumps-forge-1.18.1-8.0.0+5.jar
02/14/2022  06:43 PM           142,020 collective-1.18.1-4.0.jar
02/14/2022  06:04 PM           224,710 ColossalChests-1.18.1-1.8.2.jar
02/14/2022  05:51 PM           223,354 comforts-forge-1.18-5.0.0.1.jar
02/15/2022  11:06 AM           246,380 ConfigMenusForge-v3.1.0-1.18.1-Forge.jar
02/14/2022  05:20 PM           115,715 Controlling-forge-1.18.1-9.0+14.jar
02/14/2022  06:11 PM           103,976 corn_delight-1.0.0-1.18.1.jar
02/14/2022  05:53 PM            88,020 CosmeticArmorReworked-1.18.1-v1a.jar
02/14/2022  06:15 PM             5,473 CraftableElytra-1.18.1.jar
02/14/2022  05:54 PM        11,953,184 create-mc1.18.1_v0.4d.jar
02/14/2022  05:54 PM           817,839 createaddition-1.18.1-20220125a.jar
02/14/2022  05:54 PM         2,433,016 createdeco-1.2.5-1.18.jar
02/14/2022  06:15 PM           254,467 curios-forge-1.18.1-5.0.6.0.jar
02/14/2022  06:15 PM            37,239 curiouselytra-forge-1.18.1-5.0.1.0.jar
02/14/2022  06:04 PM           847,329 CyclopsCore-1.18.1-1.13.0.jar
02/14/2022  06:49 PM            62,009 Dimensional-Paintings-1.18-1.2.jar
02/14/2022  06:29 PM           235,618 EarthMobs-1.18.1-0.5.3.jar
02/14/2022  06:24 PM            84,209 EasyMagic-v3.2.1-1.18.1-Forge.jar
02/14/2022  06:29 PM           368,166 enchantwithmob-1.18.1-3.3.0.jar
02/14/2022  06:10 PM         2,532,641 FarmersDelight-1.18.1-1.0.3.jar
02/14/2022  05:46 PM             5,459 FastFurnace-1.18.1-6.0.2.jar
02/14/2022  05:24 PM             9,104 FastLeafDecay-27.2.jar
02/14/2022  05:46 PM            22,577 FastWorkbench-1.18.1-6.0.1.jar
02/14/2022  06:16 PM            14,791 feature_nbt_deadlock_be_gone_forge-1.0.0+1.18.1.jar
02/14/2022  05:54 PM         1,266,873 flywheel-forge-1.18-0.6.0.jar
02/14/2022  05:44 PM         2,138,289 furniture-7.0.0-pre28-1.18.1.jar
02/14/2022  05:45 PM           428,883 goblintraders-1.7.0-1.18.1.jar
02/14/2022  06:34 PM           181,660 guardvillagers-1.18.1.4.0.jar
02/14/2022  06:09 PM             6,420 harvest-1.18.1-1.1.jar
02/14/2022  06:03 PM            72,935 InfChest-18.4.jar
02/18/2022  08:27 PM           929,642 jei-1.18.1-9.4.1.102.jar
02/14/2022  05:20 PM         6,857,309 journeymap-1.18.1-5.8.0beta15.jar
02/14/2022  05:22 PM           245,174 JustEnoughResources-1.18.1-0.13.1.150.jar
02/14/2022  05:55 PM         7,553,651 macawsbridgesbop-1.18.1-1.0.jar
02/14/2022  05:57 PM           707,425 macawsbridgesbyg-1.18.1-1.0.jar
02/14/2022  05:58 PM           472,149 macawsroofsbop-1.18.1-1.0.jar
02/14/2022  05:58 PM         1,180,888 macawsroofsbyg-1.18.1-1.0.jar
02/14/2022  06:36 PM           856,634 Mantle-1.18.1-1.8.31.jar
02/14/2022  05:55 PM           660,889 mcw-bridges-2.0.1-mc1.18.1.jar
02/14/2022  05:58 PM           870,117 mcw-doors-1.0.5-mc1.18.1.jar
02/14/2022  05:58 PM           229,060 mcw-fences-1.0.2-mc1.18.1.jar
02/14/2022  05:58 PM           519,688 mcw-lights-1.0.2-mc1.18.1.jar
02/14/2022  05:58 PM           280,686 mcw-paintings-1.0.2-mc1.18.1.jar
02/14/2022  05:58 PM         1,614,194 mcw-roofs-2.1.0-mc1.18.1.jar
02/14/2022  05:58 PM           364,247 mcw-trapdoors-1.0.4-mc1.18.1.jar
02/14/2022  05:58 PM           798,125 mcw-windows-2.0.2-mc1.18.1.jar
02/14/2022  06:11 PM           222,200 mmlib-1.0.0-1.18.1.jar
02/14/2022  06:27 PM            30,635 MobPC-1.18-1.0.0.0.jar
02/14/2022  05:20 PM            76,344 MouseTweaks-forge-mc1.18-2.21.jar
02/19/2022  07:57 PM           305,546 movingelevators-1.3.3-mc1.18.jar
02/14/2022  06:39 PM        46,360,128 MTR-forge-1.18-3.0.0-beta-8.jar
02/14/2022  06:35 PM           121,310 NastyMobs-1.18-1.0.0.8.jar
02/14/2022  06:16 PM            11,022 no_null_processors_forge-2.0.2+1.18.1.jar
02/14/2022  05:57 PM         9,482,127 Oh The Biomes You'll Go-forge-1.18.1-1.3.5.9.jar
02/14/2022  05:43 PM           167,267 PatinaPipeworks-1.18.1-1.0.6-universal.jar
02/14/2022  05:46 PM           179,550 Placebo-1.18.1-6.1.1.jar
02/22/2022  02:23 PM            28,809 portablemobs-1.0.0-mc1.18.jar
02/14/2022  06:24 PM           106,420 PuzzlesLib-v3.1.5-1.18.1-Forge.jar
02/16/2022  08:47 PM         1,880,022 rechiseled-1.0.8-mc1.18.jar
02/14/2022  06:16 PM         5,874,006 repurposed_structures_forge-4.2.10+1.18.1.jar
02/19/2022  07:59 PM           985,980 rsgauges-1.18.1-1.2.14.jar
02/14/2022  06:14 PM           239,089 selene-1.18-1.12.0.jar
02/14/2022  05:39 PM           136,289 SereneSeasons-1.18.1-6.0.0.11-universal.jar
02/15/2022  01:29 PM         1,295,917 Shrines-1.18.1-3.0.0-Beta17.jar
02/14/2022  05:59 PM           431,221 SimpleStorageNetwork-1.18.1-1.5.3.jar
02/14/2022  06:38 PM           143,700 simplybackpacks-1.18.1-2.0.2-build.29.jar
02/14/2022  06:43 PM            12,692 smallernetherportals_1.18.1-1.9.jar
02/14/2022  06:23 PM        24,795,399 SoMSecondSemester1.18.1-3.0.10.jar
02/14/2022  06:34 PM           261,714 stoneholm-1.4.1.jar
02/16/2022  08:46 PM           154,183 supermartijn642configlib-1.0.9-mc1.18.jar
02/16/2022  08:47 PM           206,608 supermartijn642corelib-1.0.16b-mc1.18.jar
02/14/2022  06:14 PM        13,792,956 supplementaries-1.18.1-1.1.11.jar
02/14/2022  05:58 PM            22,820 swingthroughgrass-1.18.1-1.8.0.jar
02/14/2022  06:36 PM        12,396,707 TConstruct-1.18.1-3.4.1.46.jar
02/14/2022  05:23 PM           176,836 TerraBlender-forge-1.18.1-1.1.0.75.jar
02/19/2022  07:57 PM        68,225,153 The_Undergarden-1.18.1-0.6.3.jar
02/21/2022  06:51 PM           135,863 trashcans-1.0.12-mc1.18.jar
02/15/2022  11:09 AM            65,914 veinmining-forge-1.18.1-0.17.jar
02/14/2022  06:34 PM            44,785 VillagersRespawn-1.18.1-1.39.0.5.jar
02/15/2022  05:18 PM           332,549 wthit-forge-4.5.1.jar

This is all that is in the logs between 2 times that the elevator cabin size settings needed to be re-configured

[13:53:14] [Server thread/INFO]: clouddesu was slain by Hoglin
[13:53:14] [Render thread/INFO]: [CHAT] clouddesu was slain by Hoglin
[13:53:14] [Render thread/INFO]: TextComponent{text='clouddesu', siblings=[], style=Style{ color=null, bold=null, italic=null, underlined=null, strikethrough=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null, font=minecraft:default}} died at BlockPos{x=33, y=65, z=-92}. Deathpoints enabled: true. Deathpoint created: true
[13:53:24] [Render thread/INFO]: Mapping halted in C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\minecraft:the_nether
[13:53:24] [Render thread/INFO]: Started 10 worker threads
[13:53:25] [Render thread/INFO]: Started 10 worker threads
[13:53:25] [Render thread/WARN]: Received passengers for unknown entity
[13:53:25] [Render thread/INFO]: Started 10 worker threads
[13:53:25] [Render thread/INFO]: Loaded 5 waypoints from C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\waypoints
[13:53:25] [Render thread/INFO]: Mapping started in C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\overworld. Memory: 13920MB total, 1726MB free 
[13:55:29] [Render thread/INFO]: Mapping halted in C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\minecraft:overworld
[13:55:29] [Render thread/INFO]: Started 10 worker threads
[13:55:30] [Render thread/INFO]: Loaded 5 waypoints from C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\waypoints
[13:55:30] [Render thread/INFO]: Mapping started in C:\Users\Hibiya\AppData\Roaming\ATLauncher\instances\Trains\journeymap\data\sp\dennys\the_nether. Memory: 13920MB total, 2193MB free 
[13:55:55] [Render thread/WARN]: Received passengers for unknown entity
[13:56:03] [Render thread/INFO]: Loaded 2337 advancements
[13:56:19] [Render thread/WARN]: Received passengers for unknown entity
[13:56:28] [Render thread/WARN]: Received passengers for unknown entity
[13:56:32] [Render thread/WARN]: Received passengers for unknown entity
[13:56:45] [Render thread/INFO]: Loaded 2337 advancements
[13:56:56] [Render thread/WARN]: Received passengers for unknown entity
[13:57:06] [Server thread/INFO]: clouddesu was doomed to fall
[13:57:06] [Render thread/INFO]: [CHAT] clouddesu was doomed to fall
SuperMartijn642 commented 2 years ago

I don't feel like downloading all those mods one by one. Could you try to narrow down the mods conflicting with Moving Elevators? Or, if you are using the CurseForge launcher, could you export the profile from the launcher and send me the zip file so I can import it? image

JeremyToler commented 2 years ago

I understand I also would not want to download all those mods. Here is the exported config. https://mega.nz/file/C7xmxBxB#jgxdVOsVTxUq9drGBNzeDCjMmq0TpXNDahbisk4ieS8

SuperMartijn642 commented 2 years ago

When using the profile you send me, I can still change the cabin size just fine.

You send also send me part of log before, is that log from the server or from the client? And do you have the log from the other side for me as well?

JeremyToler commented 2 years ago

The log was from the server side. I'm not experiencing the issue any more, I'm not sure what happened..

SuperMartijn642 commented 2 years ago

Were you using an elevator from before the 1.3.0 update of Moving Elevators?

If that's the case, I think it might be something with updating the elevator data from older versions of Moving Elevators.

JeremyToler commented 2 years ago

Sorry for the delay.. I was not using Moving Elevators prior to 1.3.0, I only set up this world a few weeks ago.

I am having the issue again but now I am also having similar issues with JourneyMap and a magic mod. I think this is not an issue with your mod but something else.

LordMaximus05 commented 2 years ago

I am also having this issue, I didnt want to start a new thread tho. everytime the server restarts or my area is unloaded the cabin resets to the default size and location.

SuperMartijn642 commented 2 years ago

Could you send the latest.log files for both the server and client from when this happens?

K3shin commented 2 years ago

Hi,

I have the same problem. Settings are not saved on the server. I tried it only with the necessary mods:

In single player I can't save settings in Nether. if I set up an elevator in Nether, leave and return through the portal, the settings will be reset.

By the way, if I use the "Magnesium" mod, it is not possible to change the appearance of the control panel. Forge version: 1.18.1-forge-39.1.0 K3shin

SuperMartijn642 commented 2 years ago

@K3shin could you upload the latest.log files from when this happens?

K3shin commented 2 years ago

I sent the logs by mail.

testing process:

SuperMartijn642 commented 2 years ago

I finally found the problem. The elevator data got erased when the chunk the elevator is located in gets unloaded without the world getting unloaded. I usually just test in the overworld where I happen to spawn, however the spawn chunks always stay loaded thus I never encountered the issue. 🤦‍♂️

I fixed it now in Moving Elevators 1.3.6. Thank you all for helping me out!

mbergfors commented 2 years ago

Awesome news, congrats! I'll patch and holler if I spot it still being strange. Thanks very much.

K3shin commented 2 years ago

Thank you very much. Great work! I love your mod.