[Bug] Phasing through elevator as it goes up

Kowantify commented 1 year ago

Version Info

Minecraft 1.19.2
Moving Elevators 1.3.11a

**Are you using OptiFine? No, I'm using Rubidium

Description of the Bug Whenever going down on the elevator I don't have issues, but going up I phase through the floor every time

Steps to Reproduce Place an elevator, go up a floor, immediately phase through the floor, even on lowest blocks per tick setting

Screenshots

2023-01-28_13 44 32 2023-01-28_13 44 33 2023-01-28_13 44 34 2023-01-28_13 44 35 2023-01-28_13 44 35_2 2023-01-28_13 44 37 2023-01-28_13 44 38 2023-01-28_13 44 39 2023-01-28_13 44 39_2

Kowantify commented 1 year ago

This is happening in a quite large modpack, I'm not entirely sure what mod I have that is messing with moving entity's and so forth, but it definitely is messing with the mod, as the mod works fine with rubidium as tested

Kowantify commented 1 year ago

but when I go down the elevator it isn't smooth at all, my character stutters essentially, but when I test it by itself with some basic mods it's completely fine, is there a know mod that isn't compatible?>

SuperMartijn642 commented 1 year ago

What you're describing sounds a known issue with OptiFine. Are you sure you are not using OptiFine? As far as I know Rubidium just has performance optimizations and what you have in those screenshots looks like shaders.

If it's not OptiFine, you'll have to do some investigating to find which other mod is causing the issue.

Kowantify commented 1 year ago

100% not optifine, I've been doing modpacks for a very very long time, Optifine is trash, I've literally removed half my mods, it worked, removed the other half, it worked, I'm beyond confused, but I think it's a combo of mods that causes it, usually the motion of the elevator moving is very smooth, but it isn't anymore, What type of mod would mess with the elevator? I'll attach my mods I'm using, I tried removing 20 mods at a time to test but this is incredibly tedious and difficult to narrow down

What your seeing is "oculus" but it works just fine without the modpack, when it is just oculus and rubidium

Kowantify commented 1 year ago

This is the modpack list and the links to the curseforge pages in the modpack, I've also tested like I stated by removing half, tested, it worked, removed the other half, tested, it worked, all together, doesn't work, I'm beyond confused on what is could possibly be, hopefully this modlist will have somthing stick out as messing with moving tile entities

SuperMartijn642 commented 1 year ago

Moving Elevators relies on handling player movement for the elevator at the end of each tick, so most likely it would be a mod that messes with player movement in some way. The only mods that stand out to me from that are Canary and Better Animation Collection. Could be any of them though, just those two caught my attention. If it's not one of those, I can probably look into it tomorrow.

Kowantify commented 1 year ago

I removed all mods.. Issue is persising, with ONLY moving elevators installed

Kowantify commented 1 year ago

Forge Version, 43.2.4, Moving Elevators 1.3.11a, SMConfigLib: 1.1.6b, SMCoreLIb: 1.1.1a 1.19.2

No other mods installed elevator stutters, player falls through as elevator goes up

Kowantify commented 1 year ago

https://user-images.githubusercontent.com/35680697/215293424-53d03030-ffb2-4344-a6e3-2b8d92932324.mov

Ignore the incredibly low quality, had to edit it via davinci resolve to meet the 10MB cap for file uploads on github

This is with the mod only install, brand new world, all new testing, most recent forge version, and this happens

Kowantify commented 1 year ago

Forge version 43.2.0, Works Forge version 43.2.1, Works Forge Version 43.2.2, Works Forge Version 43.2.3, Works Forge Version 43.2.4, Doesn't Work

That's the problem, it is just the most recent version of forge causing an issue

SuperMartijn642 commented 1 year ago

Yup that seems to be it. Forge changed LevelTickEvent to also be fired on the client-side in 43.2.4. Moving Elevators used LevelTickEvent server-side and ClientTickEvent client-side to handle the elevator movement. Since LevelTickEvent is now also fired client-side, the elevator's movement handling got called twice every tick leading to the issues you were experiencing. A one line check does the trick for fixing it in 9fd0203118c38fad24cb769481e8de148be5b76e.

Should be fixed now in version 1.3.11b of Moving Elevators for 1.18, 1.19.2, and 1.19.3. Thanks a lot for the help and reporting the issue!

Kowantify commented 1 year ago

Thank you so much for looking into this and fixing it so fast!

SuperMartijn642 / MovingElevators

[Bug] Phasing through elevator as it goes up #152