SuperMartijn642 / PackedUp

3 stars 6 forks source link

[Question] Opening/Closing #57

Closed FallenOfficer closed 1 year ago

FallenOfficer commented 1 year ago

Question I know you can open the bags with "O" but you can't seem to close them with "O" but closes with "E" and "Escape." Is that meant to be? Is there a way to change it in the files to both open and close with "O"?

darkwiz666 commented 1 year ago

You can change the key in your Keybinds menu, but looking over PackedUpClient.java it's intentional by misdesign (forgot to register o as both open+close, as only open is there, and E/Esc must be somewhere else.

I'll also point out the rename screen doesn't close when you hit Enter...something you'd do to confirm input. ¯_(ツ)_/¯

SuperMartijn642 commented 1 year ago

looking over PackedUpClient.java it's intentional by misdesign (forgot to register o as both open+close, as only open is there, and E/Esc must be somewhere else.

Wut 🤔

In version 1.0.30 of Packed Up, you can now close the backpack inventory screen using the open key bind and you can close the rename screen by enter. Thank you for the suggestions!

darkwiz666 commented 1 year ago

Don't know why they didn't just call it unintentional, but I figure it's like the difference in a rocket for space travel and rocket for artillery: you're only thinking of "😈 GO 😈" for one, and they thought of "please stop" before go for the other because of the consequences; just forgot to make it the same bind ( ͡~ ͜ʖ ͡°)

As for

E/Esc must be somewhere else. I figured MC was handling it since I couldn't find where the Esc/E binds were, so I figured mc handles that as a fallback for opening dialog (I mean, that's what I'd have done anyway).

Thanks for the rapid update