SuperMartijn642 / Pottery

1 stars 1 forks source link

[Bug] Custom pots interfere with passive particle generation #7

Closed Arkraze closed 1 month ago

Arkraze commented 3 months ago

Version Info

What mod loader are you using?: Fabric 0.15.11

Description of the Bug Placing a custom pot causes campfires (normal, soul, & signal fire) to incorrectly generate smoke, either making none or a constant stream of particles, depending on placement timing. Removing all custom pots or moving beyond the block entity render distance of the pots fixes the smoke, but rebreaks when a pot is placed or comes back in sight. Persists if the pots are occluded or behind the camera, and through relaunch.

Steps to Reproduce Place any Pottery pot, of any color, and a campfire, in any order.

Screenshots 2024-06-26_00 27 14 2024-06-26_00 27 20

Arkraze commented 3 months ago

Did some further testing, the issue is on 1.20.1 fabric as well. There are no logged errors. The default pot and block entities from your Benched mod don't present these issues, if that helps.

Persists through settings changes (some of dubious relevance):

Persists through pot interactions:

Interferes with passively generated particles (non-comprehensive):

No interference on ephemeral particles (non-comprehensive):

2024-07-06_19 57 43

SuperMartijn642 commented 1 month ago

Seems the rendering was resetting the random state, hence anything determined from the random after would be the same every time. I fixed it now in Pottery version 1.0.2. Thank you for reporting the issue!