[Bug] Scarecrow causes extreme amounts of fish to spawn

SuperMartijn642 / ScarecrowsTerritory

3 stars 8 forks source link

[Bug] Scarecrow causes extreme amounts of fish to spawn #9

Closed SteveoUK closed 2 years ago

SteveoUK commented 2 years ago

Version Info

Minecraft, 1.17.1
Scarecrow's Territory, scarecrowsterritory-1.1.3-mc1.17

Description of the Bug When placed near or on the ocean, it fills with 1000s of mobs, and after 5 or so seconds crashes the game, if use /kill to remove all entities, it will kill thousands. I did reproduce with only scarecrows territory mod enabled. all overs disabled, same result.

Steps to Reproduce Place over/under or near ocean biome.

Screenshots 2021-10-09_20 10 11 2021-10-09_20 08 32

msticninja commented 2 years ago

Same basic issue on 1.16.5. Never seen so many mobs... 2021-11-09_13 16 59 .

SuperMartijn642 commented 2 years ago

Welp, I found the problem. So vanilla uses a factor / Math.pow(17, 2) for calculating mob caps. I accidentally wrote that as / 17 * 17 instead of / (17 * 17). Thus, scarecrows used a mob cab 289 times larger than vanilla. Whoops

I fixed it now in Scarecrows' Territory version 1.1.3b for 1.16 and 1.1.3a for 1.17. Thank you both for reporting the issue!