SuperMartijn642 / SimpleMagnets

3 stars 12 forks source link

[Feature] Support for Mekanism magnets #53

Open MuteTiefling opened 9 months ago

MuteTiefling commented 9 months ago

Is your feature request related to a problem? Please describe. Mekanism magnets pick up items that are protected by SimpleMagnets anti magnet coils

Describe the solution you'd like There appears to be two standards at work here. No clue what's best, but Mekanism is apparently working with vanilla standards while this is working with a modded standard that many, but not all, magnets support.

https://github.com/mekanism/Mekanism-Feature-Requests/issues/630#issuecomment-1931017515

Would be nice if the Antimagnets here could work for both.

SuperMartijn642 commented 9 months ago

As far as I can tell, all that Mekanism does is check if an item pickup delay https://github.com/mekanism/Mekanism/blob/18afdb60f1297c81cd4db5dffd4e44ed98c955d5/src/main/java/mekanism/common/content/gear/mekasuit/ModuleMagneticAttractionUnit.java#L48. The demagnetization coils are just intended to prevent magnets from attracting items. Setting a pickup delay on the item would also prevent players from just picking up the item normally which I don't want.

MuteTiefling commented 9 months ago

Understandable. Thanks for looking into it