SuperMartijn642 / SuperMartijn642sCoreLib

14 stars 2 forks source link

[Crash] ... #14

Closed JLSkyzer closed 1 year ago

JLSkyzer commented 1 year ago

Version Info

Steps to Reproduce Crash on startup [crash-2023-01-07_20.00.03-client.txt]

Crash report (~/logs/latest.log) (https://github.com/SuperMartijn642/SuperMartijn642sCoreLib/files/10367081/crash-2023-01-07_20.00.03-client.txt) debug.log latest.log

JLSkyzer commented 1 year ago

Core lib = Latest

SuperMartijn642 commented 1 year ago

You are using version 1.1.0 of my core library. Please update to 1.1.0a and see if the issue persists.

JLSkyzer commented 1 year ago

I already use the 1.1.0a and that not work is the reason why i take the 1.1.0

JLSkyzer commented 1 year ago

and the error is the same

Lothloriian commented 1 year ago

I'm having a very similar issue that seems to be coming from this particular core lib. It flagged on the portablemobs but I deleted that one and got the same error for additional lanters.
mc crash

Lothloriian commented 1 year ago

And I tried both separate versions I found of it on curseforge, both together and separate.

SuperMartijn642 commented 1 year ago

@Lothloriian this is completely unrelated to the issue above. Portable Mobs has not been updated for version 1.1 of my core library. All of my own mods have, make sure to update them all.

Lothloriian commented 1 year ago

Interesting. I'll try and revert my recent update and see what I find.

JLSkyzer commented 1 year ago

any idea for my crash ?

RedRaspberry commented 1 year ago

Having a very similar crash myself with the latest (1.1.1) release Crashlog is incredibly sparse on info, annoyingly, but I've confirmed it's corelib with a binary search

crash-2023-01-11_01.09.34-client.txt

SyluxS7 commented 1 year ago

I found the culprit... apparently, it's a Mixin issue. Downloaded Mixin 0.7-0.8 Compatibility to fix it and the game is now running fine. Hope it solves the issue for you too.

Update: Here is versions I use for the Forge part: image

SuperMartijn642 commented 1 year ago

Thanks @SyluxS7, hadn't even thought of that. If that does turn out to be the issue others are experiencing, I will just add Mixin 0.7-0.8 Compatibility as a dependency on CurseForge so hopefully most people won't run in to this issue.

@JLSkyzer and @RedRaspberry, could you check if adding Mixin 0.7-0.8 Compatibility fixes the issue for you too?

SuperMartijn642 commented 1 year ago

That looks like it's has nothing to do with this issue. Could you create an issue for it on Connected Glass' repository? https://github.com/SuperMartijn642/ConnectedGlass/issues

JLSkyzer commented 1 year ago

i test that

JLSkyzer commented 1 year ago

crash again for, he crash on the stage "2/7" crash-2023-01-18_11.06.09-client.txt

JLSkyzer commented 1 year ago

LanguageLoader

Magic1578 commented 1 year ago

Game crashes and won't start

Minecraft version: 1.12.2 Forge version: 14.23.5.2860 SuperMartijn642's Core Lib Version: 1.1.1

latest.log

SuperMartijn642 commented 1 year ago

Finally had some time to actually look into the issue.

@Magic1578 Although a very similar crash, your crash is unrelated to the original issue. This was simply due to a mistake in one of my mixins and because that particular class only rarely gets loaded, it's not particularly obvious.

As for the main issue by @JLSkyzer, the crash only occurs when Hammer Lib, ColorUtility, and my core library are installed. Disable any one of them and the game loads without issue. It seems to be caused by ColorUtility loading their resources in a hacky way and using an invalid modid (they use capitals in the modid for the resource pack, whilst no capital letters are allowed). Normally ColorUtility doesn't seem to load any translations, however Hammer Lib seems to try to load translations for other mods (no clue why), thus triggering my LanguageLoader for ColorUtility.

This is ultimately an issue with ColorUtility, however I have now added an additional check for cases like this.

Both, the crash from @Magic1578 and from @JLSkyzer, have now been fixed in version 1.1.1a for Minecraft 1.12. Thank you all for reporting the issues and helping me out!