search

SuperMartijn642 / SuperMartijn642sCoreLib

14 stars 4 forks source link

[Crash] Optifine #4

Closed Sephiroth91 closed 2 years ago

Sephiroth91 commented 2 years ago

Version Info

If I take Optifine in the mod folder, minecraft is crashing while loading. If there is no Optifine in the mod folder it works well.

Crash report (~/logs/latest.log) ... latest.log

SuperMartijn642 commented 2 years ago

OptiFine changes a lot about Minecraft's rendering, however, it is also closed source, thus there's no way for others to know what it changes. I will look into it, but there's likely nothing I can do about it.

iammael commented 2 years ago

I'm having the same issue with 1.0.15a. At first, I thought it was linked to the MalisisCore issue that is closed but it actually seems to be Optifine.

The version 1.0.14 doesn't have that issue, which might help you pinpoint the problem.

Sephiroth91 commented 2 years ago

I can confirm that. I have tested it. With version 1.0.14 all works

SuperMartijn642 commented 2 years ago

Yes, in 1.0.15 I added a mixin for a Minecraft method EntityRenderer#renderWorldPass. Apparently, OptiFine completely changes that method, however I have no way to know what it looks like after OptiFine changed it as OptiFine is closed source.

iammael commented 2 years ago

I understand. Maybe put a warning somewhere that your lib latest version won't be able to run on modpacks running Optifine ?

LoneWolfGmer commented 2 years ago

this does indeed seem to be an issue I myself spent 4 hours trying to fix after updating my copy of this very mod from 11/13/2021 supermartijn642corelib-1.0.14-mc1.12.jar Release 1.12.2

to the latest also. yes using optifine was likely the issue. but I need my dynamic lightings

a warning about this issue would be useful though for sure

LoneWolfGmer commented 2 years ago

Version Info

* Minecraft, 1.12.2, Forge 2855

* Core Lib: 1.0.15a

If I take Optifine in the mod folder, minecraft is crashing while loading. If there is no Optifine in the mod folder it works well.

Crash report (~/logs/latest.log) ... latest.log

also a note on this. my copy doesn't even run it just gets stuck in a loop. being between running and not in a crashed but running state.

going back to supermartijn642corelib-1.0.14-mc1.12.jar

seemed to be a fix though for me. and those who want to use optifine

MrRedstoneA1 commented 2 years ago

Also had this issue. Thought it was a mod incompatibility but then tried in a clean install, only to find that it still crashes with the only other mod being Optifine. I keep a clean testing install that only has Optifine for compatibility reasons (say, if a mod isn't happy with some Optifine setting I could report it to the dev)

SuperMartijn642 commented 2 years ago

Core library version 1.0.16a will now work with OptiFine again on Minecraft 1.12.

Thank you all for reporting the issue.