SuperMartijn642 / SuperMartijn642sCoreLib

14 stars 2 forks source link

Update SpongePowered to 8.5 #58

Closed OptimusZeGaming closed 7 months ago

OptimusZeGaming commented 7 months ago

A commit to update spongepowered to 8.5

SuperMartijn642 commented 7 months ago

What is the reason for this PR, why would mixin need to be updated?

Mixin 0.8.2 is the latest version of mixin which doesn't break other mods using a mixin version older than 0.8.2. Hence I specifically chose to include that version.

OptimusZeGaming commented 7 months ago

What is the reason for this PR, why would mixin need to be updated?

Mixin 0.8.2 is the latest version of mixin which doesn't break other mods using a mixin version older than 0.8.2. Hence I specifically chose to include that version.

The Moving Elevator mods are not compatible with the DynamX mods, as they use version 8.5, which is not compatible with version 8.2.

SuperMartijn642 commented 7 months ago

The Moving Elevator mods are not compatible with the DynamX mods

The only mod I can find with 'DynamX' in its name, is DynamX Physics Mod. I haven't had any reports from people for incompatibilities with that and seeing as the download count is not that high, I think I would rather keep support with the mods using mixin 0.8.2 or older.

... as they use version 8.5, which is not compatible with version 8.2.

Many 1.12 mods use mixin versions older than 0.8.2. This means DynamX Physics Mod will be incompatible with all of those.

I specifically copied what Mixin 0.7-0.8 Compatibility does, which is make sure mixin 0.8.2 gets loaded before any other mod loads their version of mixin. This is the only solution I found to incompatibilities with many popular 1.12 mods such as VanillaFix. Since making that change I haven't had any reports of mixin incompatibilities.

Mixin 0.8.5 is simply too new for 1.12 mods as even mixin 0.8.2 already came out 3 years after Minecraft 1.13 was released.

OptimusZeGaming commented 7 months ago

I see.

OptimusZeGaming commented 7 months ago

Can I create a release on my fork with mixin version 8.5?

SuperMartijn642 commented 7 months ago

You mean like as a release on GitHub? I don't mind that.

Just don't upload it to like CurseForge or Modrinth and that be fine 😅