search

SuperQ / smokeping_prober

Prometheus style smokeping
Apache License 2.0
554 stars 73 forks source link

Add helm chart #111

Closed jochbru closed 1 year ago

jochbru commented 1 year ago

I created a Helm chart in the following repository: https://github.com/cyso/helm-smokeping-prober

I figured it might be better to contribute it to the source project. If you want to @SuperQ, then go ahead and merge it into this project, i'll then either archive or delete the other repository.

SuperQ commented 1 year ago

Maybe this would be a better fit for https://github.com/prometheus-community/helm-charts? This way all of the automated testing tooling is available.

jochbru commented 1 year ago

Thanks for the suggestion. I have never contributed there before, but i'll see if I'm able to meet the requirements. I'll have to change some stuff with regards to versioning I think. Are there any other things you would think need attention before it could be merged?

SuperQ commented 1 year ago

I'm not totally up on the standards used in that repo. But it's a nice collection, which makes it easier for people to find this.

jochbru commented 1 year ago

I'll give it a shot! Go ahead and close this request. Thanks!

On Tue, Jul 4, 2023, 17:38 Ben Kochie @.***> wrote:

I'm not totally up on the standards used in that repo. But it's a nice collection, which makes it easier for people to find this.

— Reply to this email directly, view it on GitHub https://github.com/SuperQ/smokeping_prober/pull/111#issuecomment-1620460794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AICC6QHU2CMVKJAXBROYKWDXOQ2GTANCNFSM6AAAAAAZ5ZGCKA . You are receiving this because you authored the thread.Message ID: @.***>