search

SuperQ / smokeping_prober

Prometheus style smokeping
Apache License 2.0
554 stars 73 forks source link

grafana dashboard: latency plots overall average, should maybe average over a window? #150

Open dominikh opened 4 months ago

dominikh commented 4 months ago

The latency graph's query is currently

smokeping_response_duration_seconds_sum{host="${target:raw}"} / smokeping_response_duration_seconds_count{host="${target:raw}"}

which plots the overall average, and looks like this:

image

I believe it should instead be something like

rate(smokeping_response_duration_seconds_sum{host="${target:raw}"}[$__rate_interval]) / rate(smokeping_response_duration_seconds_count{host="${target:raw}"}[$__rate_interval])

instead, which looks like this:

image

SuperQ commented 4 months ago

Oh, I didn't notice that. Yes, that's a bug.