SuperQ / smokeping_prober

Prometheus style smokeping
Apache License 2.0
575 stars 74 forks source link

Inspect packet TTL #19

Closed SuperQ closed 5 years ago

SuperQ commented 5 years ago

The upstream go-ping library now records packet TTL. It would be good to collect this TTL.

Options for this:

I think the histogram is either not granular enough, or too much cardinality.

So I'm leaning towards just tracking the last TTL, and exposing that as a single metric per pinger.

SuperQ commented 5 years ago

/cc @zloo

zloo commented 5 years ago

Agreed with tracking just the last TTL. I don't think this value will change much, so recording it as a histogram doesn't make much sense to me. This would be a rather easy thing to add, and if someone has a use case for TTL histogram, they can create a ticket in the future.