tobbi
commented
3 months ago There's various compiler errors:
D:\a\supertux\supertux\src\video\canvas.cpp(340,21): error C2641: cannot deduce template arguments for 'std::array' [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
D:\a\supertux\supertux\src\video\canvas.cpp(340,21): error C2780: 'std::array<_Ty,_Size> std::array(void)': expects 0 arguments - 6 provided [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\utility(147,7):
see declaration of 'std::array'
D:\a\supertux\supertux\src\video\canvas.cpp(340,21): error C2780: 'std::array<_Ty,_Size> std::array(std::array<_Ty,_Size>)': expects 1 arguments - 6 provided [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\utility(147,7):
see declaration of 'std::array'
D:\a\supertux\supertux\src\video\canvas.cpp(348,26): error C2027: use of undefined type 'std::array' [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\utility(147,7):
see declaration of 'std::array'
D:\a\supertux\supertux\src\video\canvas.cpp(349,34): error C2676: binary '[': 'std::array' does not define this operator or a conversion to a type acceptable to the predefined operator [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
D:\a\supertux\supertux\src\video\canvas.cpp(349,56): error C2676: binary '[': 'std::array' does not define this operator or a conversion to a type acceptable to the predefined operator [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
D:\a\supertux\supertux\src\video\canvas.cpp(349,78): error C2676: binary '[': 'std::array' does not define this operator or a conversion to a type acceptable to the predefined operator [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
D:\a\supertux\supertux\src\video\canvas.cpp(349,5): error C2660: 'Canvas::draw_triangle': function does not take 3 arguments [D:\a\supertux\supertux\build\supertux2_lib.vcxproj]
HybridDog
Goal
There are reports that the one-dimensional OKLab color selection is unpopular and difficult to use (see this Discussion), so we can remove it to simplify the code and GUI.
A two-dimensional image can enable a more convenient selection of colors than a one-dimensional slider. Under the assumption that users typically want to select a color with the highest saturation, a two-dimensional color picker where any RGB color with the highest saturation can be slected with one click could be suitable. For an independent adjustment of lightness and hue, which is considered a good property of a color picker, the two-dimensional color picker should use a perceptual color space such as OKLab. As a side effect for choosing a perceptual color space, a marker showing the lightness and hue of the current color can visualize how a change in RGB values affects the perceived color.
Proposed changes
Additional information
The author of OKLab has a webpage about a color picker, which uses a modified lightness. I have also used the modified lightness since it leads to smaller dark regions in the color picker image and in SuperTux it is, I assume, uncommon to select dark colors (correct me if I'm wrong).
Color picker image with unmodified lightness:
Color picker image with modified lightness:
The new color picker with default language and 800x600 window size:
The color picker stretches horizontally; since the language affects the width of the menu title, the color picker's aspect ratio depends on the language. I don't think this is a problem, so I haven't implemented it differently.
I couldn't find a way to get a pixel from a Surface, so the color picker image is loaded twice: one time for the drawing and one time to sample pixel values from it.
Please test the new color picker.