search

SuperTux / supertux

SuperTux source code
https://supertux.org
GNU General Public License v3.0
2.5k stars 479 forks source link

Prevent infinite recursion in rock's grab and ungrab scripts #2907

Closed tobbi closed 4 months ago

tobbi commented 5 months ago

This prevents #2906 from happening.

weluvgoatz commented 5 months ago

I think the PR is fine; I just set a script like this in order to prevent it from running infinitely: image

weluvgoatz commented 5 months ago

However this PR does fix the crash. Thank you!!!!

tobbi commented 5 months ago

I'd really like to fix the flickering issue as well so that it only flips once.

weluvgoatz commented 5 months ago

Not sure if possible since the script seems to run every frame while the rock is being held, rather than just when you first hold it.

tobbi commented 4 months ago

I think the solution might be easier than I initially thought.