SuperTux / supertux

SuperTux source code
https://supertux.org
GNU General Public License v3.0
2.48k stars 474 forks source link

Remove/change "Hold Ctrl" Shortcut for Autotiling #2936

Open Rusty-Box opened 2 months ago

Rusty-Box commented 2 months ago

We already have another shortcut for Autotiling. It's F5, so why even keep the "Hold Ctrl" shortcut as it only conflicts with other shortcuts that use "Ctrl"?

Whenever you use any other shortcut that involves the Ctrl key, like Ctrl+S or Ctrl+T autotiling keeps getting turned on/off which is very annoying. "Ctrl" on it's own should never be a shortcut in the editor!

Also, can we switch the sorting of editor option in the menu from F5 to F8 rather than F8 to F5? Also, also, the F5 shortcut is missing in the "Keyboard Shortcut" list from the menu!

Frostwithasideofsalt commented 2 months ago

It would be nice if the keybind would just be changed to some other key instead of just removing it, as I constantly use the ctrl keybind as its more convenient to just hold a button as apposed to toggling it constantly.

MatusGuy commented 2 months ago

Ok, but how does it interfere with Ctrl+S for example? Doesn't autotile turn off upon letting go of the key?

If we really need to remove it, I would recommend the alt key instead.

Rusty-Box commented 2 months ago

Ok, but how does it interfere with Ctrl+S for example? Doesn't autotile turn off upon letting go of the key?

From my understanding the game assumes that you hold Ctrl so once you let go it will always turn off autotiling, ven if you turned it on permanetly with the F5 shortcut

bruhmoent commented 2 months ago

Can't we just enable customizable editor keybindings if we don't have that yet?

Rusty-Box commented 2 months ago

It would be nice if the keybind would just be changed to some other key instead of just removing it, as I constantly use the ctrl keybind as its more convenient to just hold a button as apposed to toggling it constantly.

As long as i is no longer Ctrl I don't care either way. Just don't have it be Ctrl.

Rusty-Box commented 2 months ago

Can't we just enable customizable editor keybindings if we don't have that yet?

Even then, the default should not be Ctrl.

Vankata453 commented 2 months ago

It may be removed from CTRL if it really is an issue, but a keybind to enable autotile mode on hold should definitely still be there - it's quite convenient.

tobbi commented 1 month ago

How about "Shift"? Easily accessible as well and doesn't interfere with anything.