search

SuperTux / supertux

SuperTux source code
https://supertux.org
GNU General Public License v3.0
2.48k stars 474 forks source link

Generate release builds as `RelWithDebInfo` #2945

Closed tobbi closed 1 month ago

tobbi commented 1 month ago

In order for the stacktrace in the crash reporter to have line numbers, we need to generate builds with debug symbols. Unfortunately, builds generated as Release do not contain that info. I'd advise generating builds as RelWithDebInfo instead.

In order to do that, all the CI files need to get changed accordingly.

tobbi commented 1 month ago

I was wrong about RelWithDebInfo generating debug symbols (line numbers). So IDK how to proceed here?

Vankata453 commented 1 month ago

I was wrong about RelWithDebInfo generating debug symbols (line numbers). So IDK how to proceed here?

Just Windows then? At least we will get stacktraces that make sense there.

tobbi commented 1 month ago

IDK anymore.

Vankata453 commented 1 month ago

Personally, on debug reports, I wouldn't necessarily care about the line numbers, as I would be able to see them by reproducing the crash on my own -ggdb debug build. Stacktraces in reports could serve as more of a general map of things, we could gather the details ourselves.

MatusGuy commented 1 month ago

Just Windows then?

Perhaps we can keep it for all platforms. Shouldn't matter that much.

Vankata453 commented 1 month ago

Shouldn't matter that much.

But what if it does? I'm not aware of the consequences of RelWithDebInfo.

MatusGuy commented 1 month ago

The only thing that could possibly be worrying is bigger file size i think. As long as Windows has it, it doesn't matter