Add Rock Tileset, Update Rock-related Sprites, and Update Signs

Eauix commented 4 months ago

This request is focused on adding to the game a new rock-themed tileset, but has many extra features and tweaks.

New features:

Conversion file to turn the addon rock tiles into vanilla rock tiles
Updated sprites for the carryable rock object along an extra 3x3 size for it
Blocky rock tiles similar to the rock sprites
Platforms and falling platforms sprites updated with current in-game tiles
New sprites for falling platforms made from the rock tileset
Redesigned rock sign and all other signs as well
Normal, Wall and Hanging sign bases added as tiles
Transparent sign icons as decals to use with the bases
Snow, Forest and Corrupted overlay decals for signs

Tweaks:

Weak and Unstable tiles (hay, ice, crumbling stone, thin ice and skulls) added to the "Bonus+Block" tilegroup
Removed the duplicated 2x2 crystal tiles in the tilegroup
Filled the empty gaps on the ice cave slopes in the tilegroup

Todo list:

[x] Add the jagged rock tile images
[x] Update rock object sprites
[x] Add rock platform sprites for the falling platforms
[x] Update the old platform sprites to fit the new game style
[x] Update the .strf and .satc files with the new tile IDs
[x] Rearrange tile IDs so they don't conflict with #2894
[x] Add a conversion file to turn the addon rock tiles into vanilla rock tiles
[x] Add rock block tiles and 3x3 carryable rock
[x] Add weak and unstable tiles as actual tiles
[x] Update sign designs
[x] Add wall and hanging sign variants

Eauix commented 4 months ago

There's a problem with changing the rock object type to "large" in the editor, it selects .png file instead of the .sprite file, I might try to find a solution for this, if changing this behavior requires recompiling the game I will need some help.

(Edit: This is no longer an issue because the new images are the same size as the hitboxes)

Eauix commented 4 months ago

I really love this tileset, just don't know where it could be used in the game. Also, I think the previous portable rock sprites might be better to use; I know they're called "rocks", but they really resemble building blocks, so having them be square/simple design would be more beneficial imo.

The tiles blend well with forest levels, and could also be used in world 3 as a rocky sea shore.

About the rock objects, I may revert them or draw a simpler shape for their sprite if needed.

Alasdairbugs commented 4 months ago

I really love this tileset, just don't know where it could be used in the game. Also, I think the previous portable rock sprites might be better to use; I know they're called "rocks", but they really resemble building blocks, so having them be square/simple design would be more beneficial imo.

disagree; these rock tiles could be used to make drawable rock objects of any shape/size/quirk. it looks more distinctive than the current ones

Rusty-Box commented 4 months ago

I see World 3 benefitting from these, specifically the beach setting. World 2 already has a bunch of things going for it for v0.7 so they most likely won't appear anywhere there. Could be useful for the bonus islands, outside of story mode.

For portable rocks I agree with Daniel, but I see them working if adjusted to stand out more as an interactable object. Right now they look too close to the tileset which could lead to some general confusion as they may blend in too well.

weluvgoatz commented 4 months ago

Now that you mention it, I think it would work well in World 3.

Eauix commented 4 months ago

Ok, now the rock sprites are done!

Eauix commented 3 months ago

I still have an open PR that also adds a bunch more tiles to the game (that being #2894) so you might have to change your tile IDs here, but I'd wait with that until this one is finalized to prevent ID conflicts.

Once I know concrete how many IDs mine adds, I'll tell you more regarding which IDs are free to use without issues.

Yeah I noticed that only after defining all my IDs, I will wait for your update and then I'll redefine it

Narre commented 3 months ago

Please don't use CRLF line endings, just WHYYYYY? (in autotiles.satc)

Eauix commented 3 months ago

Please don't use CRLF line endings, just WHYYYYY? (in autotiles.satc)

Huh, this explains why the diff considered the file to be entirely replaced. Until now I had no idea that such a thing existed, like, going from one line to other line can be done in different ways? Bruh!

I will try to find a way of fixing it

Narre commented 3 months ago

According to file, there are two different line endings in there (CRLF, the Windows way, and CR, the Apple way). Ideally, you should convert all line endings to LF (the Linux way), which is most commonly used in SuperTux.

MatusGuy commented 3 months ago

I will try to find a way of fixing it

In your text editor you should be able to specify if you want to use CRLF or LF.

Eauix commented 3 months ago

Okay, the CRLF it is fixed now!

Eauix commented 3 months ago

I still have an open PR that also adds a bunch more tiles to the game (that being #2894) so you might have to change your tile IDs here, but I'd wait with that until this one is finalized to prevent ID conflicts.

Once I know concrete how many IDs mine adds, I'll tell you more regarding which IDs are free to use without issues.

I've been thinking of leaving some free/skipped IDs for you to work with, like around 200 or 300 IDs, leaving the headers like this

  ;; next-id: 7558
  ;; free/skipped ids (please use before any other): 101, 7195-7494

But idk if this is a bad decision, considering that the ideal is always using those skipped IDs whenever they are present, and not creating more of them, I'll let you decide

Rusty-Box commented 3 months ago

I've been thinking of leaving some free/skipped IDs for you to work with, like around 200 or 300 IDs, leaving the headers like this

I would advise against that.

However, my PR is almost done, I wanna make sure it ready by the end of the day so you can adjust yours pretty soon. Been quite busy lately so it fell to the way side a bit.

Eauix commented 3 months ago

However, my PR is almost done, I wanna make sure it ready by the end of the day so you can adjust yours pretty soon.

Oh, okay then

Eauix commented 3 months ago

As #2894 has been closed, i'll start working on redefining the rock tile IDs

Eauix commented 3 months ago

I'm going to start it from the beginning, due to lots of conflicts

Eauix commented 3 months ago

Okay, I readded everything and a little bit more, it should be complete now

Update: It's NOT complete

Eauix commented 1 month ago

Okay, after adding these overlays, I can say now that the PR is complete and ready for a review!

SuperTux / supertux

Add Rock Tileset, Update Rock-related Sprites, and Update Signs #2960