search

SuperTux / supertux

SuperTux source code
https://supertux.org
GNU General Public License v3.0
2.49k stars 470 forks source link

Improved Flame #3004

Open Sevenberry opened 1 month ago

Sevenberry commented 1 month ago

Added colored flames, interaction with magic tiles, and flame particle trails.

Rusty-Box commented 1 month ago

First!

tobbi commented 1 month ago 
 src/object/moving_sprite.cpp:260:19: style: Redundant assignment of 'angle' to itself. [selfAssignment]
      float angle = angle;
                  ^
src/object/moving_sprite.cpp:260:21: error: Uninitialized variable: angle [legacyUninitvar]
      float angle = angle;
                    ^
tobbi commented 1 month ago 
/Users/runner/work/supertux/supertux/src/badguy/flame.hpp:31:16: error: 'after_editor_set' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void after_editor_set();
               ^
/Users/runner/work/supertux/supertux/src/badguy/badguy.hpp:76:16: note: overridden virtual function is here
  virtual void after_editor_set() override;
               ^
/Users/runner/work/supertux/supertux/src/badguy/flame.cpp:39:3: error: field 'lightcolor' will be initialized after field 'sound_source' [-Werror,-Wreorder-ctor]
  lightcolor(1.0f, 1.0f, 1.0f),
tobbi commented 1 month ago

I seem quite the party-pooper by only pointing out compiler errors. Sorry about that.