[Bug]: Why can't I look up/down/left/right with WASD?

communist1917 commented 1 month ago

SuperTux Version

0.6.3

System Information

Manjaro Linux XFCE

Expected Behavior

I expect looking up or down or left of right

Actual Behavior

Pressing either W or A or S or D does nothing, view of level is not moving a pixel in any direction.

Steps To Reproduce Actual Behavior

Press either W or A or S or D.

Additional Information

No response

Guidelines For Reporting Issues

[X] I have read https://github.com/SuperTux/supertux/blob/master/CONTRIBUTING.md#bug-reports.
[X] I have verified this isn't an issue that's already been reported.
[X] I have verified this isn't a discussion, or an issue about a crash or a feature request, but rather an actual bug ─ that is, the game did something not intended.
[X] I have verified this issue is not about wrong translations (use Transifex for those), or anything unsupported (e.g. third-party add-ons).
[X] In this report, I have only included details about one (1) bug.
[X] If I make a mistake while submitting this report, I agree to use the "Edit" feature to correct it, instead of closing this issue and opening a new one.

Frostwithasideofsalt commented 1 month ago

You can already change the peek keybinds to WASD in the options.

communist1917 commented 1 month ago

You can already change the peek keybinds to WASD in the options.

Thank you. In my options WASD buttons were already set as look buttons but they didn't work. Then I reset these buttons and set them again. And after I restrart Supertux they began working. This is strange.

Rusty-Box commented 1 month ago

Imo. WASD should be the default for peeking. Who uses "page-up", "delete", "home", etc. for games anyway? WASD is way more common in games to do something and is way more handy to use when the other hand is preoccupied with arrow keys, as well as being closer to Space and Ctrl. It just fit in better with all the other default key binds

communist1917 commented 1 week ago

I figured out the problem.

If I set lookup buttons as [W], [A], [S], [D] and I launch Supertux while English keyboard layout is active then these buttons will work. But if I launch Supertux while Russian keyboard layout is active, these buttons WILL NOT work.

And vice versa. If I set lookup buttons as [Ц], [Ф], [Ы] [В] when I launch Supertux while Russian keyboard layout is active, these buttons will work. If launch the game while English keyboard layout is active, it WILL NOT work.

Supertux remembers the keyboard layout at the moment it's started and then compares pressed keys with characters that correspond to lookup buttons.

If I want to play, first I have to look what my keyboard layout is, then switch to English if I set lookup buttons as [W], [A], [S], [D] and launch the game. After I launched it I can switch keyboard layout back to Russian one, Supertux will work as expected.

It's kinda annoying...

Supertux algorithm must compare key codes, not key characters.

SuperTux / supertux