search

SuperTux / supertux

SuperTux source code
https://supertux.org
GNU General Public License v3.0
2.55k stars 492 forks source link

Update collision.cpp #3096

Open Iceyshell opened 2 weeks ago

Iceyshell commented 2 weeks ago

Fix ceiling slope hang so which was fixed by others too.However,Ensure that the code is consistent in determining the validity of the p1 coordinate relative to the area range

tobbi commented 2 weeks ago

@SuperTux/developers I'm not too familiar with our collision system. Will changing rdelta negatively affect anything else?

Iceyshell commented 2 weeks ago

I reworked it and was able to implement it locally, so hopefully it will be useful for the main supertux branch!

Frostwithasideofsalt commented 1 week ago

image image

okay, so. this pr works... but not really. it makes it less common? but it still happens.

Frostwithasideofsalt commented 1 week ago

i'll hold off on approving until it's fully fixed