search

Superbalist / flysystem-google-cloud-storage

Flysystem Adapter for Google Cloud Storage
MIT License
265 stars 105 forks source link

Use get instead of has in getOptionsFromConfig #35

Closed Tobiasartz closed 8 years ago

Tobiasartz commented 8 years ago

getOptionsFromConfig ignores any configuration that has been set directly on the Adapter's defaults.

In the current state using this example:

            'filesystem' => new Filesystem($cachedAdapter2, array(
                'visibility' => AdapterInterface::VISIBILITY_PUBLIC,
            ))

the "visibility" setting is ignored

For extra clarification have a look at Config->has

cedricziel commented 8 years ago

Looks good to me