search

Superbalist / flysystem-google-cloud-storage

Flysystem Adapter for Google Cloud Storage
MIT License
265 stars 105 forks source link

google/cloud-storage version constraint #83

Closed albertborsos closed 6 years ago

albertborsos commented 6 years ago

Is there any reason for this constraint? https://github.com/Superbalist/flysystem-google-cloud-storage/blob/master/composer.json#L14

I am using google/cloud-storage 1.5, that is why I cannot install a package which fails on this dependency.

Thanks

TerraSkye commented 6 years ago

if the test pass for the higher version i don't see any reason to not bumb the version constraint. as far is i know it was locked because we need to make sure it keeps working. so if a PR with a constraint to 1.5 succeeds i think we can up the constraint.

albertborsos commented 6 years ago

Thanks. I made a PR: #84

ftrotter commented 6 years ago

This is a show-stopping bug for installation on current versions of php with current versions of google/cloud-storage..

please accept pull request if possible.

-FT