search

Superbalist / flysystem-google-cloud-storage

Flysystem Adapter for Google Cloud Storage
MIT License
265 stars 105 forks source link

bugfix: generate rfc 3986 compliant urls #90

Closed tpetry closed 5 years ago

tpetry commented 6 years ago

Generating an uri with whitespaces or any other characters besides alphanumeric characters or "-_.~" will not be RFC 3986 compliant. They will work in most browsers because they are automatically encoded but may fail when passed to other software modules which are not doing automatic encoding.

This pull request will change url generation slightly that they are still pointing to the same destination but all url special characters are encoded for software that does not do the encoding by itself.

koenvdheuvel commented 5 years ago

This implementation looks good to me.

@nicja could you take a look at this? PR has been open for over a year.

Much appreciated.