search

Superbalist / flysystem-google-cloud-storage

Flysystem Adapter for Google Cloud Storage
MIT License
265 stars 105 forks source link

Fix deleteDir #92

Closed Yo1L closed 5 years ago

Yo1L commented 6 years ago

A directory is not removed if we only delete the object directory. We need to remove recursively all files and remove the directory itself !

fgilio commented 5 years ago

This PR fixes an important problem with the package, pls merge it

nicja commented 5 years ago

The tests for this are failing, we need someone to take a look before we can merge this

jimmypuckett commented 5 years ago

This is duplicated by #94. Given that the other MR has passing test, can we use it?

I am with @fgilio in that this is important as it is the expected behavior given how the other drivers work.

Thanks!

nicja commented 5 years ago

Closed in favour of #94