Add a --setenv IV_GUI_VER when calling OpenVPN

[GoogleCodeExporter]

Recent OpenVPN version allow the UI to report its version to be reported to the 
server.  This helps adminstrators debug issues with clients. The OpenVPN 
Connect and OpenVPN for Android clients already do this.

For details see
https://github.com/OpenVPN/openvpn/commit/f3a2cd255a3bc73
later renamed to IV_GUI_VER
https://github.com/OpenVPN/openvpn/commit/c1b35689964f6910c1ea239618d42ee5e552c4
05

So tunnelblick should add a --setenv IV_GUI_VER "tunnelblick 3.4beta123" or 
--setenv  IV_GUI_VER "org.tunnelblick 3.4beta123" when calling OpenVPN.

I tried to setup a build environment to provide a patch but failed miserable :(

Original issue reported on code.google.com by arne@rfc2549.org on 25 Mar 2014 at 10:40

[GoogleCodeExporter]

Thank you very much for your suggestion. This is a good idea; I plan to 
implement it soon.

Tunnelblick (and OS X applications generally) have two "versions":
 * CFBundleVersion: used to compare versions to see which one is newer
 * CFBundleShortVersionString: the "marketing" version

The commit seems to indicate that the correct argument for Tunnelblick 
3.4beta20 (build 3727) could be either
     "net.tunnelblick.tunnelblick 3727"
which can be easily parsed but doesn't include the "3.4beta20" part, or maybe
     "net.tunnelblick.tunnelblick 3727 3.4beta20 (build 3727)"
which includes all of the version info but isn't easily parsed for the build 
number.

So I think I will make it
    "net.tunnelblick.tunnelblick 3727 3.4beta20 (build 3727)"
which is easily parsed to get the build # AND also contains the full version 
info.

It isn't inconsistent with the description
     "<gui_id><space><version>"
to extend that to be
     "<gui_id><space><build-number><space><human-readable-version>"
which is easily parsed for either the build number or a human-readable version 
string.

This isn't set in stone -- I welcome any comments/reactions.

Original comment by jkbull...@gmail.com on 25 Mar 2014 at 11:05

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

HOWEVER: The latest release of OpenVPN (2.3.2), which is imbedded in 
Tunnelblick does not support this feature.

So until 2.3.3 is released, it won't really work.

I intend to include it soon, anyway -- adding the environment variable won't 
break anything.

Original comment by jkbull...@gmail.com on 25 Mar 2014 at 11:18

[GoogleCodeExporter]

Yeah. I think using   
"<gui_id><space><build-number><space><human-readable-version>" should be fine. 

Original comment by arne@rfc2549.org on 25 Mar 2014 at 11:20

[GoogleCodeExporter]

point taken, will release 2.3.3 "ASAP" :-) (there's still a few bugs in our 
trac that I want to address first)...

Original comment by gdoer...@gmail.com on 25 Mar 2014 at 1:16

[GoogleCodeExporter]

I have committed (as r2781) code to set the IV_GUI_VER environment variable to

     "<gui_id><space><build-number><space><human-readable-version-string>".

Examples:
     "net.tunnelblick.tunnelblick 2781 3.4beta21 (build 2781)".
     "net.tunnelblick.tunnelblick 9999 3.4 (build 9999)".

Original comment by jkbull...@gmail.com on 28 Mar 2014 at 11:25

• Changed state: Fixed

[GoogleCodeExporter]

A snapshot (pre-release version) of Tunnelblick is available that (I hope) 
fixes this problem is available; email me directly for a link to it.

Original comment by jkbull...@gmail.com on 4 Apr 2014 at 12:02